-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
77 split the first intervention into a casual observation and the intervention itself #86
Conversation
… `samplingProtocol` is empty
Blocked by review and #94 |
As discussed in our meeting yesterday, we decided to put this PR on hold. We considered that it might not be convenient to split occurrences after all. The idea behind the split is the following. For the early alert tool, we want to know when a species was first observed at a certain location. This is the first record within an event for which The "hack" described in this PR would be a first step in resolving this issue. For each event (all records with the same After a discussion with @damianooldoni and @peterdesmet, we suggest to use another approach: all records with the following conditions are considered to be management actions:
For these records, However, as there are a lot of uncertainties at this point, we decided to put this PR on hold. |
I'm still expecting some information from RATO on this topic, they are going to investigate on the data model side if they can come up with some sort of ruling on what is an intervention, and what isn't. I understand that for now, we will not be populating any records I've converted this PR to draft, as it's no longer in the queue for merging to main. |
As per #134 we a no longer planning to split records, but instead use a decision tree to decide if a record should be considered a casual observation, or an intervention. |
What changed?
Splitting the first intervention of an event into an observation, and the original intervention
The mapping now looks for the first record of every event that meets the following criteria:
dossier_status == "Opvolging"
samplingProtocol
These records get duplicated, and assigned a new
occurrenceID
which is the same as the original source record, but with a suffix:-cas
, and get thesamplingProtocol
set tocasual observation
.setting a samplingProtocol for observations
When the following criteria are met:
dossier_status != "Verwerkt en afgesloten"
samplingProtocol
There records are assigned the value
casual observation
forsamplingProtocol
Other
Some small improvements to code documentation and clarity, added a failure mode for duplicate
occurrenceID
's, added a simple test for the changes above.I'm open to any idea's for a more thorough test. What could we check to make sure the new changes to the mapping keep having the desired effect. Any examples of what could go wrong?
Before Review:
Questions for review
dossier_status == "Opvolging"
, anddossier_status == "Verwerkt en afgesloten"
are still making it to the occurrence.csv. This is supposed to happen, right?Difference between old an new mapping outputs
For the review, from the same raw data:
Only the differences between the two: 20231130_diff_rato_mapping.html (Download, and open with browser)