Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better feature parity with JS SDK #34

Merged
merged 2 commits into from
Mar 11, 2022
Merged

Conversation

joao-conde
Copy link
Contributor

@joao-conde joao-conde commented Mar 11, 2022

Issues: https://github.com/ripe-tech/ripe-pulse/issues/301

Added missing methods. Ran cleanup also.

@joao-conde joao-conde added the enhancement New feature or request label Mar 11, 2022
@joao-conde joao-conde requested a review from BeeMargarida March 11, 2022 10:52
@ripe-tobias-bot
Copy link

Woof, Woof!

Thank you @joao-conde for submitting the "feat: better feature parity with JS SDK" pull request 😎.

Please do not forget to review our internal guidelines:

  • Review the code in the PR using a peer 🧑‍🤝‍🧑
  • Make sure all the linting process has been executed an passed 👌
  • Make sure unit tests are passing ✅
  • Ensure that proper code standards are met 📋
  • Fill in the PR's summary (issue, dependencies, decisions and GIF)
  • Double-check the diff to make sure it's the absolute best solution you can come up with

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend,
Tobias (Platforme's mascot)

Tobias Bot

@coveralls
Copy link

coveralls commented Mar 11, 2022

Pull Request Test Coverage Report for Build 167

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 161: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@3rdvision 3rdvision requested a review from joamag March 11, 2022 11:37
@3rdvision 3rdvision assigned joamag and unassigned 3rdvision Mar 11, 2022
@joamag joamag merged commit 0157a68 into master Mar 11, 2022
@delete-merged-branch delete-merged-branch bot deleted the jc/feat-add-new-endpoints branch March 11, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants