Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: general order chat methods #37

Merged
merged 2 commits into from
Mar 23, 2022
Merged

feat: general order chat methods #37

merged 2 commits into from
Mar 23, 2022

Conversation

joao-conde
Copy link
Contributor

@joao-conde joao-conde added the enhancement New feature or request label Mar 23, 2022
@joao-conde joao-conde requested a review from BeeMargarida March 23, 2022 11:06
@ripe-tobias-bot
Copy link

Woof, Woof!

Thank you @joao-conde for submitting the "feat: general order chat methods" pull request 😎.

Please do not forget to review our internal guidelines:

  • Review the code in the PR using a peer 🧑‍🤝‍🧑
  • Make sure all the linting process has been executed an passed 👌
  • Make sure unit tests are passing ✅
  • Ensure that proper code standards are met 📋
  • Fill in the PR's summary (issue, dependencies, decisions and GIF)
  • Double-check the diff to make sure it's the absolute best solution you can come up with

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend,
Tobias (Platforme's mascot)

Tobias Bot

@joao-conde joao-conde requested a review from BeeMargarida March 23, 2022 11:39
@BeeMargarida BeeMargarida requested a review from 3rdvision March 23, 2022 11:41
@3rdvision 3rdvision assigned joao-conde and unassigned 3rdvision Mar 23, 2022
@coveralls
Copy link

coveralls commented Mar 23, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 196

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%
Totals Coverage Status
Change from base Build 191: 0.0%
Covered Lines: 0
Relevant Lines: 0
💛 - Coveralls

@joao-conde joao-conde requested a review from 3rdvision March 23, 2022 14:35
@joao-conde joao-conde assigned 3rdvision and unassigned joao-conde Mar 23, 2022
@3rdvision 3rdvision assigned joao-conde and unassigned 3rdvision Mar 23, 2022
@joao-conde joao-conde assigned 3rdvision and unassigned joao-conde Mar 23, 2022
@3rdvision 3rdvision requested a review from joamag March 23, 2022 15:37
@3rdvision 3rdvision removed their assignment Mar 23, 2022
@joamag joamag merged commit 641471f into master Mar 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the jc/4702-general-order-chat branch March 23, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeeMargarida BeeMargarida BeeMargarida approved these changes

@3rdvision 3rdvision 3rdvision approved these changes

@joamag joamag joamag approved these changes

Assignees

@joamag joamag

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joao-conde @coveralls @joamag @3rdvision @BeeMargarida