Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: brand and model in data j for logic script #40

Closed
wants to merge 3 commits into from

Conversation

joao-conde
Copy link
Contributor

No description provided.

@joao-conde joao-conde added enhancement New feature or request fast-track Feature to be fixed or implemented ASAP labels May 2, 2022
@joao-conde joao-conde requested a review from joamag May 2, 2022 16:00
@ripe-tobias-bot
Copy link

Woof, Woof!

Thank you @joao-conde for submitting the "feat: brand and model in data j for logic script" pull request 😎.

Please do not forget to review our internal guidelines:

  • Review the code in the PR using a peer 🧑‍🤝‍🧑
  • Make sure all the linting process has been executed an passed 👌
  • Make sure unit tests are passing ✅
  • Ensure that proper code standards are met 📋
  • Fill in the PR's summary (issue, dependencies, decisions and GIF)
  • Double-check the diff to make sure it's the absolute best solution you can come up with

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend,
Tobias (Platforme's mascot)

Tobias Bot

@ripe-tobias-bot
Copy link

Woof, Woof!

Oops! @joao-conde it looks like the PR check have just failed.

Please try to fix them as soon as possible.

Your friend,
Tobias (Platforme's mascot)

Tobias Bot

@ripe-tobias-bot ripe-tobias-bot bot assigned joao-conde and unassigned joamag May 2, 2022
@ripe-tobias-bot ripe-tobias-bot bot added the blocked ⛔ Something is blocking this issue label May 2, 2022
@joao-conde joao-conde removed the blocked ⛔ Something is blocking this issue label May 2, 2022
@joao-conde joao-conde assigned joamag and unassigned joao-conde May 2, 2022
@coveralls
Copy link

coveralls commented May 2, 2022

Pull Request Test Coverage Report for Build 216

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 212: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@ripe-tobias-bot
Copy link

Woof, Woof!

Oops! @joao-conde it looks like the PR check have just failed.

Please try to fix them as soon as possible.

Your friend,
Tobias (Platforme's mascot)

Tobias Bot

@ripe-tobias-bot ripe-tobias-bot bot assigned joao-conde and unassigned joamag May 2, 2022
@ripe-tobias-bot ripe-tobias-bot bot added the blocked ⛔ Something is blocking this issue label May 2, 2022
@joamag
Copy link
Contributor

joamag commented May 2, 2022

Closing this as redundant

@joamag joamag closed this May 2, 2022
@joamag joamag deleted the jc/feat-add-brand-model branch May 2, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked ⛔ Something is blocking this issue enhancement New feature or request fast-track Feature to be fixed or implemented ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants