feat: port query to spec & other utils #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joao-conde
commented
Jun 6, 2022
joao-conde
commented
| - | - |
|---|---|
| Issue | -- |
| Dependencies | -- |
| Decisions | Port of useful functions from the javascript RIPE SDK to our python SDK. |
| Animated GIF | -- |
joao-conde
added
enhancement
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
Unit testing would be great to check that everything is working as expected and since this is not API calls, it can be tested |
Pull Request Test Coverage Report for Build 245
💛 - Coveralls |
BeeMargarida
approved these changes
Jun 7, 2022
3rdvision
requested changes
Jun 7, 2022
3rdvision
approved these changes
Jun 7, 2022
|
Woof, Woof! Oops! @joao-conde it looks like you've assigned the issue to multiple persons. There can only be one person assigned - @joao-conde was removed from issues assignees list. Your friend, |
joamag
reviewed
Jun 10, 2022
| @@ -54,6 +54,127 @@ class API( | |||
| transport_rule.TransportRuleAPI, | |||
| availability_rule.AvailabilityRuleAPI, | |||
| ): | |||
| @classmethod | |||
| def _query_to_spec(cls, query): | |||
There was a problem hiding this comment.
nothing should come before init
| return spec | ||
|
|
||
| @classmethod | ||
| def _unpack_query(cls, query): |
There was a problem hiding this comment.
let's move all these methods to a util_api.py
There was a problem hiding this comment.
Also didnt like these in the main class but didnt know what to call the new file since api was weird. util api it is 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.