Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WS-173] WalletConnect v2 EthereumProvider #68

Merged
merged 9 commits into from
Jun 28, 2023
Merged

[WS-173] WalletConnect v2 EthereumProvider #68

merged 9 commits into from
Jun 28, 2023

Conversation

deivrios
Copy link

@deivrios deivrios commented Jun 27, 2023 •
edited
Loading

Type of MR:

  • Feature
  • Fix
  • HotFix

Small description:
Update ModalConnector with WalletConnect v2, extending from BrowserWeb3Connector and using EthereumProvider as a replacement for window.ethereum.

Aditional observations/considerations:
...

Checklist:

  • My code follows the styleguides of the project (successfully pass linters)
  • I tested my code.
  • I commented/docummented my code in a way that complex parts are explained.
  • If required, i updated project's README file.
  • I added/updated tests that tests my changes in code.
  • All previous and new tests pass.
  • I commit any new dependency.
  • I updated UML diagram in confluence if any model was modified in this MR.

@deivrios deivrios self-assigned this Jun 28, 2023
@deivrios deivrios merged commit 705108a into develop Jun 28, 2023
@semantic-release-ripio-bot
Copy link
Collaborator

🎉 This PR is included in version @ripio/sdk-modal-connector-v1.0.0-dev.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedeaviles fedeaviles fedeaviles approved these changes

@AgusVelez5 AgusVelez5 AgusVelez5 approved these changes

@mauricio-b-r mauricio-b-r Awaiting requested review from mauricio-b-r

Assignees

@deivrios deivrios

Labels
released on @develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deivrios @semantic-release-ripio-bot @AgusVelez5 @fedeaviles