Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip leading and trailing quotes from search values #392

Closed
ckniffen opened this issue Oct 7, 2022 · 1 comment
Closed

Strip leading and trailing quotes from search values #392

ckniffen opened this issue Oct 7, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ckniffen
Copy link
Collaborator

ckniffen commented Oct 7, 2022

Per @legleux

“copy to clipboard” buttons on the explorer raw page copies the quotes too (which is fine bc you’d need them for pasting sometimes) but the search input should at least strip quotes instead of saying “page not found”

Simply removing any leading " or ' from the search string before applying parsing logic will fix this annoyance.
@ckniffen ckniffen added enhancement New feature or request good first issue Good for newcomers labels Oct 7, 2022
@jonathanlei jonathanlei mentioned this issue Jun 26, 2023
Merged
@ckniffen
Copy link
Collaborator Author

Fixed by #759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ckniffen