Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strip leading and trailing quotes from search #759

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

jonathanlei
Copy link
Contributor

@jonathanlei jonathanlei commented Jun 26, 2023

High Level Overview of Change

referring to issue #392
programmatically strip the quotes
Before:
Screenshot 2023-06-26 at 3 00 43 PM

after:
Screenshot 2023-06-26 at 3 00 06 PM

@justinr1234
Copy link
Collaborator

Do we also strip leading and trailing space?

@ckniffen
Copy link
Collaborator

Please add a test.

@ckniffen
Copy link
Collaborator

Do we also strip leading and trailing space?

stripping leading and spaces would be good too.

@jonathanlei
Copy link
Contributor Author

Do we also strip leading and trailing space?

stripping leading and spaces would be good too.

actually we do strip it already -

handleSearch(event.currentTarget?.value?.trim())

@jonathanlei jonathanlei merged commit 99f00d1 into staging Jun 26, 2023
4 checks passed
@jonathanlei jonathanlei deleted the strip-search-quotes branch June 26, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants