Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledgers page index.html redirect #1022

Merged
merged 4 commits into from
Aug 6, 2024
Merged

Conversation

achowdhry-ripple
Copy link
Collaborator

@achowdhry-ripple achowdhry-ripple commented Aug 1, 2024

High Level Overview of Change

Obseleted path (/index.html) now redirects to current path to ledgers page (/).

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Translation Updates
  • Release

TypeScript/Hooks Update

  • Updated files to React Hooks
  • Updated files to TypeScript

Before / After

Test Plan

@achowdhry-ripple achowdhry-ripple marked this pull request as ready for review August 1, 2024 16:16
@pdp2121
Copy link
Collaborator

pdp2121 commented Aug 1, 2024

Actually can you add a test similar to this one:
https://github.com/ripple/explorer/blob/staging/src/containers/App/test/App.test.jsx#L147-L162

Also, probably adding to the PR description explaining why this change is needed

@pdp2121 pdp2121 self-requested a review August 1, 2024 18:05
@achowdhry-ripple achowdhry-ripple merged commit 7570cb1 into staging Aug 6, 2024
4 checks passed
@achowdhry-ripple achowdhry-ripple deleted the ledgers-page-redirect branch August 6, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants