Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: begin the switch to RTL #530

Closed
wants to merge 47 commits into from
Closed

test: begin the switch to RTL #530

wants to merge 47 commits into from

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Jan 5, 2023

High Level Overview of Change

Context of Change

Waiting for the Streams refactor, because the tests are failing there for some reason

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

TypeScript/Hooks Update

  • Updated files to React Hooks
  • Updated files to TypeScript

Before / After

Test Plan

@mvadari
Copy link
Collaborator Author

mvadari commented Jan 20, 2023

It's failing the LedgersPage tests, which I haven't even touched in this PR. Going to wait for those to be refactored.

These tests are failing because for some reason, in Streams.addLedger, the setState happens after the return of the function. I assume this would be fixed through hooks.

@mvadari
Copy link
Collaborator Author

mvadari commented Feb 14, 2023

This might be relevant for fixing the TS issues: vitest-dev/vitest#664

@ckniffen ckniffen mentioned this pull request Apr 13, 2023
@mvadari
Copy link
Collaborator Author

mvadari commented Feb 22, 2024

Closing in favor of the cleaner version: #945

@mvadari mvadari closed this Feb 22, 2024
@mvadari mvadari mentioned this pull request Apr 18, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant