feat: add support for hooks metadata details #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangell7
approved these changes
Jun 27, 2023
ckniffen
reviewed
Jun 28, 2023
src/containers/Accounts/AccountHeader/BalanceSelector/BalanceSelector.tsx
Show resolved
Hide resolved
pdp2121
approved these changes
Jun 29, 2023
ckniffen
reviewed
Jun 29, 2023
ckniffen
reviewed
Jun 29, 2023
ckniffen
requested changes
Jul 10, 2023
ckniffen
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR adds processing for hook-related info, namely
EmitDetails,HookParameters, andHookExecutionsto theDetailedtab for transactions. It also fixes an issue where the Explorer thought hook-emitted transactions were sent with a ticket, due to an assumption that used to be true but is not with hooks.Context of Change
Better hooks support
Type of Change
TypeScript/Hooks Update
All files touched already use Hooks and TypeScript.
Before / After
Sequence
Before:
After:
Hook Details
Test Plan
CI passes. Works locally.