Clawback transaction #764
Clawback transaction #764
Conversation
|
Can you add a I think you can just put amount and holder for |
src/containers/shared/components/Transaction/Clawback/Simple.tsx
Outdated
Show resolved
Hide resolved
Or treat it like partial payments with a callout? |
How much would it matter? The only thing that's relevant in a successful clawback transaction is how much token that was actually clawed back. The only time when the actual amount is different from the specified is if the holder owns less token than the specified amount, in which case, the issuer claws back the entirety of the holder's supply. The actual amount clawed back will always less than or equal to the specified amount. There is not much information lost here. And if the person wants to know what the request looked like, they could always look at the raw JSON. |
src/containers/shared/components/Transaction/Clawback/TableDetail.tsx
Outdated
Show resolved
Hide resolved
| const createWrapper = createSimpleWrapperFactory(Simple) | ||
|
|
||
| describe('Clawback', () => { | ||
| it('handles Clawback simple view ', () => { |
There was a problem hiding this comment.
Can you add a test where the clawback amount is less than the Amount field?
There was a problem hiding this comment.
The example JSON I've used does claw back less than specified.
High Level Overview of Change
If the tx is a success, the actual amount that was clawed back is returned and shown in all components.
If the tx failed, the attempted amount is shown in all components.
Context of Change
Clawback transaction. See https://github.com/XRPLF/XRPL-Standards/pull/104/files?short_path=cb82c33#diff-cb82c337d579659136224b35dbbaac97d0ffaa3cfaa79981f1bebf4f4888feb5
Type of Change
TypeScript/Hooks Update
Before / After
Successful Simple
Failed Simple
Success table detail
Failed table detail
Description
Test Plan