feat: use xrpl.js types and simplify tx parsers #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckniffen
force-pushed
the
feature/use-xrpl-js-types-take-2
branch
from
060df10
to
0f3f90b
Compare
jonathanlei
reviewed
Jul 7, 2023
No because this just updated types and parsers. Since only the output displayed the the user was changed no tests should need to be updated. |
mvadari
reviewed
Jul 10, 2023
src/containers/shared/components/Transaction/EscrowCancel/Description.tsx
Show resolved
Hide resolved
mvadari
reviewed
Jul 10, 2023
src/containers/shared/components/Transaction/EscrowCreate/Description.tsx
Show resolved
Hide resolved
mvadari
reviewed
Jul 10, 2023
| ) => { | ||
| const { t, i18n } = useTranslation() | ||
| const language = i18n.resolvedLanguage | ||
| const { data } = props | ||
| const deleted: any = findNode(data, 'DeletedNode', 'Escrow') | ||
| const deleted: any = findNode(data.meta, 'DeletedNode', 'Escrow') |
mvadari
reviewed
Jul 10, 2023
src/containers/shared/components/Transaction/EscrowFinish/parser.ts
Outdated
Show resolved
Hide resolved
mvadari
reviewed
Jul 10, 2023
src/containers/shared/components/Transaction/PaymentChannelClaim/parser.ts
Show resolved
Hide resolved
mvadari
reviewed
Jul 10, 2023
| @@ -18,7 +18,7 @@ export const Description = ({ | |||
| tx.CancelAfter && | |||
| localizeDate(convertRippleDate(tx.CancelAfter), language, DATE_OPTIONS) | |||
|
|
|||
| const node = findNode(data, 'CreatedNode', 'PayChannel') | |||
| const node = findNode(data.meta, 'CreatedNode', 'PayChannel') | |||
There was a problem hiding this comment.
Shouldn't this happen in the parser?
mvadari
reviewed
Jul 10, 2023
mvadari
reviewed
Jul 10, 2023
mvadari
reviewed
Jul 10, 2023
Co-authored-by: Mayukha Vadari <[email protected]>
mvadari
approved these changes
Jul 25, 2023
jonathanlei
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
MemosandMetadata.defaultParser.parseris now an option property of aTransactionMapping.Type of Change
Future updates
Use more types from xrpl.js once they are exported and fixed.