Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switch to react18-json-view #890

Merged
merged 9 commits into from
Jan 5, 2024
Merged

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Dec 1, 2023

High Level Overview of Change

This PR replaces react-json-view with react18-json-view. This results in 18 less dependencies and a 2kb smaller gzipped bundle.

There were a few small tweaks to the json view themes to use the closest color within the sites color palette (previously they were one offs) and margins/padding.

Context of Change

react-json-view doesn't work with React 18 and is also much bigger than react18-json-view. Related to #668.

mac-s-g/react-json-view#441

Type of Change

  • Refactor (non-breaking change that only restructures code)

TypeScript/Hooks Update

N/A

Before / After

Before:
JSON-View-Before

After:
JSON-View-After

Test Plan

Works locally. Passes CI.

@mvadari mvadari changed the title refactor: switch to react18-json-view refactor: switch to react18-json-view Dec 1, 2023
@mvadari mvadari mentioned this pull request Dec 1, 2023
@mvadari mvadari requested a review from ckniffen December 4, 2023 16:28
@ckniffen ckniffen self-assigned this Dec 6, 2023
@ckniffen ckniffen marked this pull request as ready for review December 6, 2023 21:50
@ckniffen ckniffen requested review from justinr1234, khancode, JST5000 and bugsbunnies and removed request for ckniffen December 6, 2023 21:50
Copy link
Collaborator Author

@mvadari mvadari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - can't approve since it's originally my PR

Copy link
Contributor

@JST5000 JST5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckniffen ckniffen merged commit cceb18a into staging Jan 5, 2024
4 checks passed
@ckniffen ckniffen deleted the react18-json-view branch January 5, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants