Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove the use of redux #984

Open
wants to merge 13 commits into
base: staging
Choose a base branch
from
Open

refactor: remove the use of redux #984

wants to merge 13 commits into from

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented May 20, 2024

High Level Overview of Change

This PR removes the last of redux from the codebase. The only two pieces left were Account and Token.

Context of Change

Type of Change

  • Refactor (non-breaking change that only restructures code)

TypeScript/Hooks Update

N/A

Test Plan

Tests were fixed to handle the refactor.

@@ -270,6 +262,12 @@ describe('App container', () => {
event: 'screen_view',
network: 'mainnet',
},
{
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why these test outputs changed. This should be investigated before this PR is merged.

@mvadari mvadari requested review from ckniffen and pdp2121 May 21, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant