XLS-33 Multi Purpose token #989
Conversation
|
|
||
| const AccountAssetTabDisconnected = ({ account }: Props) => { | ||
| const { id: accountId = '', assetType = assetTypes[0] } = | ||
| useRouteParams(ACCOUNT_ROUTE) | ||
|
|
||
| const supportsMPT = ['mpt_sandbox', 'devnet'].includes( |
There was a problem hiding this comment.
I would assume this is just for testing?
There was a problem hiding this comment.
Currently we have an alt server for testing. But assuming if the amendment is activated on mainnet, then this code would need to be removed
| @@ -0,0 +1,15 @@ | |||
| @import '../shared/css/variables'; | |||
|
|
|||
| .mpt-page { | |||
There was a problem hiding this comment.
Not necessarily needed in this PR but we should create a template for token pages so that there'd be not a lot of copy & paste needed (same with the Header stylings)
|
I'm not sure which way is better: the current way of showing scaled amount, or just showed the amount divided by 10^scale (so that on payment and clawback simple page we dont have to click on the token itself to find out about the scale). Other than that, looks good to me. |
|
The failed tests can be fixed when merging latest changes from staging |
Personally, I'd rather see the scaled amount instead of having to do the math myself. |
@mvadari @pdp2121 One problem with showing the amount divided by 10^scale that is the information of the AssetScale is stored in the MPTokenIssuance object. This means that whenever MPT amount is display, we would need to make an extra call using the ledger_entry API to fetch the MPTokenIssuance object to get the scale. |
I think that's fine. |
Yes. I would prefer seeing the scaled amount. We are also showing scaled amount in PriceOracles tx. |
…pled` (ripple#1033) ## High Level Overview of Change <!-- Please include a summary/list of the changes. If too broad, please consider splitting into multiple PRs. --> Resolve ripple#358 ### Type of Change <!-- Please check relevant options, delete irrelevant ones. --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Refactor (non-breaking change that only restructures code) - [ ] Tests (You added tests for code that already exists, or your new feature included in this PR) - [ ] Documentation Updates - [ ] Translation Updates - [ ] Release ## Before / After <!-- If just refactoring / back-end changes, this can be just an in-English description of the change at a technical level. If a UI change, screenshots should be included. --> ### Before  ### After 
Not quite sure why the lint fails, the ones that are failing are the ones that my local linter told me to fix. |
High Level Overview of Change
Context of Change
Spec: https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-0033d-multi-purpose-tokens
MPT page
Ledger view
MPTokenIssuance
MPTokenAuthorize
MPTokenIssuanceSet
Payment (with scaling MPT amount)
Clawback
Type of Change
TypeScript/Hooks Update
Before / After
Test Plan