Skip to content

Conversation

Arielfoever
Copy link
Contributor

No description provided.

@TommyMurphyTM1234
Copy link
Collaborator

@cmuellner
Copy link
Collaborator

Thanks for the PR!

This PR references the untagged commit 9483020ea576516448f6e820fba4b14257d6268e from the remote branch releases/gcc-15. We prefer referencing tagged commits unless there are good reasons to update to something more recent. So please set the commit to 1b306039ac49f8ad91ca71d3de3150a3c9fa792a, which is tagged with releases/gcc-15.1.0.

We also have an allowlist for failing test cases in this repository (see directory test/allowlist/gcc).
It would be great to clean this list up for the new GCC release (i.e. there should be zero failing tests after the allowlist has been applied):

  • add failing tests to the allow list with a reference to a GCC bugzilla ticket (to ensure the bug is tracked upstream)
  • remove items in the allowlist that are not needed anymore

@Arielfoever
Copy link
Contributor Author

Thanks for the PR!

This PR references the untagged commit 9483020ea576516448f6e820fba4b14257d6268e from the remote branch releases/gcc-15. We prefer referencing tagged commits unless there are good reasons to update to something more recent. So please set the commit to 1b306039ac49f8ad91ca71d3de3150a3c9fa792a, which is tagged with releases/gcc-15.1.0.

We also have an allowlist for failing test cases in this repository (see directory test/allowlist/gcc). It would be great to clean this list up for the new GCC release (i.e. there should be zero failing tests after the allowlist has been applied):

* add failing tests to the allow list with a reference to a GCC bugzilla ticket (to ensure the bug is tracked upstream)

* remove items in the allowlist that are not needed anymore

I removed all white list. I will check the result and make a new white list.

@Arielfoever Arielfoever marked this pull request as draft May 9, 2025 09:19
@Arielfoever Arielfoever force-pushed the gcc branch 2 times, most recently from 1422420 to 842244d Compare May 14, 2025 12:14
@Arielfoever Arielfoever marked this pull request as ready for review May 15, 2025 12:13
@Arielfoever
Copy link
Contributor Author

Ok I make a script and use it to gen the whitelists by math methods/

@Arielfoever Arielfoever force-pushed the gcc branch 4 times, most recently from 7b02042 to ff30585 Compare May 17, 2025 07:33
@Arielfoever
Copy link
Contributor Author

@cmuellner @TommyMurphyTM1234 ready to merge

@cmuellner
Copy link
Collaborator

Thanks for providing the allow list!

I see tons of RVV issues, a few xtheadvector issues, a few gfortran issues, a few rv32 issues and the two test cases slt-1.c and pr112398.c. @kito-cheng, you might be interested in the updated list.

Please drop the first commit (disabling the fail early) from the PR. I think it would just lead to wasted CPU cycles in most situations.

@Arielfoever
Copy link
Contributor Author

Thanks for providing the allow list!

I see tons of RVV issues, a few xtheadvector issues, a few gfortran issues, a few rv32 issues and the two test cases slt-1.c and pr112398.c. @kito-cheng, you might be interested in the updated list.

Please drop the first commit (disabling the fail early) from the PR. I think it would just lead to wasted CPU cycles in most situations.

The first commit is now dropped.

@cmuellner
Copy link
Collaborator

I like the idea of the script, as updating the allow list was the number one blocker for updating GCC in the past.
Is it right that the four text files are generated from the output of the testsuite-filter script?
Did you create the text files locally, or did you get the build log from the CI/CD artefacts?

Copy link
Collaborator

@cmuellner cmuellner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Arielfoever
Copy link
Contributor Author

I like the idea of the script, as updating the allow list was the number one blocker for updating GCC in the past. Is it right that the four text files are generated from the output of the testsuite-filter script? Did you create the text files locally, or did you get the build log from the CI/CD artefacts?

from CI log.

@Arielfoever
Copy link
Contributor Author

I like the idea of the script, as updating the allow list was the number one blocker for updating GCC in the past. Is it right that the four text files are generated from the output of the testsuite-filter script? Did you create the text files locally, or did you get the build log from the CI/CD artefacts?

from CI log.

  • Step 1: run ci without fast fail and all removed whitelist.
  • Step 2: download the raw log.
  • Step 3: edit input file in gen.py
  • Step 4: run gen.py
  • Step 5: copy the result files to whitelist.

All white list are generate by steps above except that I add one testcase since somehow it's failed sometimes but not always.

@pz9115
Copy link
Contributor

pz9115 commented May 21, 2025

LGTM, thanks for this work.

@cmuellner cmuellner merged commit 84c3086 into riscv-collab:master May 21, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants