-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gd32vw55x flash driver #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi, Jack thanks for your work on OpenOCD. Here are some coding formatting some issues, please refer to the attachment for fixes. |
} | ||
|
||
# Allow overriding the Flash bank size | ||
if { [info exists FLASH_SIZE] } { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't see any use for _FLASH_SIZE
, line 32 has flash_size set to 0x400000.
|
||
|
||
# Work-area is a space in RAM used for flash programming | ||
if { [info exists WORKAREASIZE] } { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't see any use for _WORKAREASIZE
, line 11 has work-area-size set to 20480.
Hi @JackChenHR , could you do some update to your code reviewed by @Alan-19950616 |
Hi @Alan-19950616 you can provide some steps regarding how to check styles locally to @JackChenHR |
@Alan-19950616 Yes, please help provide a local method to check the code format. thanks! |
Hi @JackChenHR , I checked https://openocd.org/doc-release/doxygen/patchguide.html#stepbystep this page, you can take a try. @Alan-19950616 Please provide a step by step example later to check the patch style, not just the link I provided. |
Hi @JackChenHR, here is the script you can check your commit patch You need to install # since you have commit two commits, this diff is HEAD~2 , if you have more commits, such as 4, change to HEAD~4
git diff -U20 HEAD~2 | filterdiff -x "a/src/jtag/drivers/libjaylink/*" -x "a/tools/git2cl/*" -x "a/.github/*" | ./tools/scripts/checkpatch.pl --no-signoff -
# then you will be able to see style check output in command window |
Signed-off-by: JackChenHR <[email protected]>
Hi @JackChenHR , I have merged the changes into our branch, thanks for your contribution, could you take a try with the nuclei/2023.10 branch, and see whether it works as expected to debug your device. |
gigadevice risc-v mcu