feat(binder): support “primary key (a, b)” syntax

[shmiwy]

Signed-off-by: Shmiwy [email protected]

#625 1st editon

support primary key (a, b) syntax by adding a field called primary_key_ids in TableCatalog without removng is_primary field from ColumnDesc. I will remove is_primary and refactor code when I want to extend the case to multiple sort keys.

[skyzh]

LGTM, good work!

[skyzh]

It seems that this logic still cannot tell the difference between primary key (a, b) and primary key (b, a)? May fix this in later PRs.

[shmiwy]

primary_key_ids is a vector， maybe we can tell the difference by index？

[shmiwy]

@skyzh

primary_key_ids is vector， maybe we can tell the difference by index？

risinglight/src/catalog/table.rs

Lines 15 to 25 in d28389a

	struct Inner {
	name: String,
	/// Mapping from column names to column ids
	column_idxs: HashMap<String, ColumnId>,
	columns: BTreeMap<ColumnId, ColumnCatalog>,
	#[allow(dead_code)]
	is_materialized_view: bool,
	next_column_id: ColumnId,
	primary_key_ids: Vec<ColumnId>,
	}

[skyzh]

But when generating primary_key_ids in TableCatalog::new, we simply iterate from the first column to the end. So for both cases, it will produce the same order. It seems that the order in Unique constraint is not retained?

[shmiwy]

oh, I forget this...

[skyzh]

oh, I forget this...

May also add a test case for this in the future :)