Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binder/chore: remove drop test #811

Merged
merged 1 commit into from
Nov 22, 2023
Merged

binder/chore: remove drop test #811

merged 1 commit into from
Nov 22, 2023

Conversation

caicancai
Copy link
Contributor

@caicancai caicancai commented Nov 21, 2023 •
edited
Loading

@caicancai
Copy link
Contributor Author

At present, drop test is not necessary, one is that this code is not used

let catalog = Arc::new(RootCatalog::new());
        catalog
            .add_table(0, "mytable".into(), vec![], false, vec![])
            .unwrap();

@caicancai
Copy link
Contributor Author

cc @wangrunji0408

@wangrunji0408 wangrunji0408 added this pull request to the merge queue Nov 22, 2023
Merged via the queue into risinglightdb:main with commit bd8fe1c Nov 22, 2023
4 checks passed
@caicancai caicancai deleted the drop_test branch November 22, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangrunji0408 wangrunji0408 wangrunji0408 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caicancai @wangrunji0408