Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(catalog): add function catalog #827

Merged
merged 1 commit into from
Jan 13, 2024
Merged

feat(catalog): add function catalog #827

merged 1 commit into from
Jan 13, 2024

Conversation

xzhseh
Copy link
Contributor

@xzhseh xzhseh commented Jan 13, 2024 •
edited
Loading

As titled, as a preparation for sql (and maybe more...) udf.

Currently FunctionCatalog stores fairly simple things:

  • function name
  • argument types
  • return type of the function
  • the language used by function definition
  • function body (i.e., the actual definition)

cc @wangrunji0408.

@xzhseh xzhseh force-pushed the xzhseh/function-catalog branch from 8a89972 to bdd64eb Compare January 13, 2024 01:47
@wangrunji0408 wangrunji0408 self-requested a review January 13, 2024 06:27
wangrunji0408
wangrunji0408 approved these changes Jan 13, 2024
View reviewed changes
Copy link
Member

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wangrunji0408 wangrunji0408 added this pull request to the merge queue Jan 13, 2024
Merged via the queue into risinglightdb:main with commit d12049a Jan 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangrunji0408 wangrunji0408 wangrunji0408 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xzhseh @wangrunji0408