improve individual test matching and output #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuchen Liang <[email protected]>
Signed-off-by: Yuchen Liang <[email protected]>
Signed-off-by: Yuchen Liang <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
skyzh
approved these changes
Dec 7, 2024
yliang412
added a commit
to cmu-db/optd
that referenced
this pull request
Dec 10, 2024
…ution (#262) Part of #263. ## Problem There is a lack of performance evaluation in optd. Without proper benchmarking, we will not know if some changes cause significant regression in performance. We should keep track of the two aspects of optimizer performance: - plan generation time - actual execution time ## Summary of changes - Add a [Criterion-rs](https://bheisler.github.io/criterion.rs/book/) based benchmark to measure optd performance. - Use the `sqlplannertest` yaml-based setup, bench if there is a `bench` task. - Bump `sqlplannertest` to version 0.4. - better individual test matching added in risinglightdb/sqlplannertest-rs#9 Planning: - Input: SQL statement (aka `datafusion_sql::parser::Statement`). - Measures the time it takes to generate a datafusion physical plan. Execution: - Input: datafusion physical plan outputted from optd (aka `Arc<dyn ExecutionPlan>`). - Measures the time it takes to execute the entire query. ## Next Steps https://github.com/benchmark-action/github-action-benchmark can directly take `cargo bench` results as input. So it will be easy to set up CI. --------- Signed-off-by: Yuchen Liang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to match selected test modules or files. Also display test names with module hierarchy.
Before
$ cargo run -p naivedb --bin apply Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.03s Running `target/debug/apply` [DONE] ok.yml, took 1 ms [DONE] error.yml, took 1 ms $ cargo nextest run -p naivedb ok Finished `test` profile [unoptimized + debuginfo] target(s) in 0.02s ------------ Nextest run ID 44de9a31-bc77-41c3-90d5-def47c4694dd with nextest profile: default Starting 1 test across 3 binaries (1 test skipped) PASS [ 0.005s] naivedb::plannertest ok ------------ Summary [ 0.005s] 1 test run: 1 passed, 1 skippedAfter
$ cargo run -p naivedb --bin apply -- basics ok Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.09s Running `target/debug/apply basics ok` [DONE] basics/create.yml, took 1 ms [DONE] basics/select.yml, took 1 ms [DONE] ok.yml, took 1 ms $ cargo nextest run -p naivedb basics::create ok Finished `test` profile [unoptimized + debuginfo] target(s) in 0.02s ------------ Nextest run ID 3789c774-11bc-4d06-98ec-2d8dde74789e with nextest profile: default Starting 2 tests across 3 binaries (2 tests skipped) PASS [ 0.005s] naivedb::plannertest basics::create PASS [ 0.004s] naivedb::plannertest ok ------------ Summary [ 0.005s] 2 tests run: 2 passed, 2 skipped