Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: turn license.passAsFile to true and mark it as deprecated #139

Merged
merged 3 commits into from
Dec 24, 2024
Merged

chore: turn license.passAsFile to true and mark it as deprecated #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00ad34d
chore: turn license.passAsFile to true and mark it as deprecated
arkbriar Dec 13, 2024
19642f7
Merge branch 'main' into shunjie/deprecate-license-pass-as-file
arkbriar Dec 24, 2024
e7fdfea
Inc version
arkbriar Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/risingwave/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.2.11
version: 0.2.12

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
6 changes: 6 additions & 0 deletions charts/risingwave/tests/license_standalone_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ set:
enabled: true
tests:
- it: no license key
set:
license:
passAsFile: false
asserts:
- notContains:
path: spec.template.spec.containers[0].env
Expand Down Expand Up @@ -59,6 +62,7 @@ tests:
set:
license:
key: "ABC"
passAsFile: false
asserts:
- contains:
path: spec.template.spec.containers[0].env
Expand Down Expand Up @@ -114,6 +118,7 @@ tests:
- it: license key found with secret ref and not passing by file
set:
license:
passAsFile: false
secret:
name: LICENSE-SECRET
key: LICENSE-KEY
Expand Down Expand Up @@ -177,6 +182,7 @@ tests:
- it: license key found with secret ref and key and not passing by file
set:
license:
passAsFile: false
key: "ABC"
secret:
name: LICENSE-SECRET
Expand Down
6 changes: 6 additions & 0 deletions charts/risingwave/tests/license_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ chart:
version: 0.0.1
tests:
- it: no license key
set:
license:
passAsFile: false
asserts:
- notContains:
path: spec.template.spec.containers[0].env
Expand Down Expand Up @@ -56,6 +59,7 @@ tests:
set:
license:
key: "ABC"
passAsFile: false
asserts:
- contains:
path: spec.template.spec.containers[0].env
Expand Down Expand Up @@ -111,6 +115,7 @@ tests:
- it: license key found with secret ref and not passing by file
set:
license:
passAsFile: false
secret:
name: LICENSE-SECRET
key: LICENSE-KEY
Expand Down Expand Up @@ -174,6 +179,7 @@ tests:
- it: license key found with secret ref and key and not passing by file
set:
license:
passAsFile: false
key: "ABC"
secret:
name: LICENSE-SECRET
Expand Down
7 changes: 4 additions & 3 deletions charts/risingwave/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1434,7 +1434,8 @@ license:
##
key: "licenseKey"

## @param passAsFile Pass the license key as a file. Defaults to false.
## Will be removed once RisingWave v2.1 is released.
## Deprecated. Will be removed once RisingWave v2.2 is released.
## @param passAsFile Pass the license key as a file. Defaults to true.
## Set it to false if you are deploying RisingWave < v2.1.
##
passAsFile: false
passAsFile: true
Loading