Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump 1.2.0 #14

Closed
wants to merge 24 commits into from
15 changes: 13 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [macos-12, self-hosted-macos-12-arm64, ubuntu-22.04]
# For macOS, large is Intel and XLarge is M1
# https://docs.github.com/en/actions/using-github-hosted-runners/about-larger-runners/about-larger-runners#about-macos-larger-runners
os: [macos-12, macos-13-large, macos-13-xlarge, ubuntu-22.04]
runs-on: ${{ matrix.os }}
env:
HOMEBREW_NO_INSTALL_FROM_API: 1 # https://github.com/Homebrew/brew/issues/15049
Expand Down Expand Up @@ -40,7 +42,16 @@ jobs:
if: github.event_name == 'pull_request'
env:
HOMEBREW_GITHUB_API_TOKEN: ${{ github.token }} # required


- name: Failures Summary and Bottle Result
if: always()
uses: Homebrew/actions/failures-summary-and-bottle-result@master
with:
workdir: ${{ github.workspace }}
result_path: bottles/steps_output.txt
step_name: 'Build failure summary on ${{ matrix.os }}'
collapse: 'true'

- name: Upload bottles as artifact
if: always() && github.event_name == 'pull_request'
uses: actions/upload-artifact@main
Expand Down
17 changes: 9 additions & 8 deletions Formula/risingwave.rb
Original file line number Diff line number Diff line change
@@ -1,18 +1,12 @@
class Risingwave < Formula
RW_VERSION = "1.1.2".freeze
RW_VERSION = "1.2.0".freeze
desc "Distributed SQL database for stream processing"
homepage "https://github.com/risingwavelabs/risingwave"
url "https://github.com/risingwavelabs/risingwave/archive/refs/tags/v#{RW_VERSION}.tar.gz"
sha256 "9f137bded84d3fe7713c4bc37674c40f6a7f1c73ef68df55a6e71f1656af5231"
sha256 "8dc4e3997941a31b3ff08ac0be760cbdcb840b8e40dcc99b40c2eafe346e034c"
license "Apache-2.0"
head "https://github.com/risingwavelabs/risingwave.git", branch: "main"

bottle do
root_url "https://github.com/risingwavelabs/homebrew-risingwave/releases/download/risingwave-1.1.2"
sha256 cellar: :any, arm64_monterey: "bc4e9742da58038881a106b2f4000f94d5ca94da96451d1b68d386f60c028894"
sha256 cellar: :any, monterey: "a23810510625b3c83fb61de6645e6b2d15c567ce1c5914ca6a872cd46aab83bc"
end

depends_on "cmake" => :build
depends_on "llvm" => :build
depends_on "protobuf" => :build
Expand All @@ -20,7 +14,7 @@
depends_on "openssl@3"
depends_on "xz"

def install

Check warning on line 17 in Formula/risingwave.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-12)

`brew install --verbose --build-bottle risingwavelabs/risingwave/risingwave` failed on macOS Monterey (12)!

cargo:warning= ^ cargo:warning= ; cargo:warning=src/../include/cxx.h:40:17: warning: rvalue references are a C++11 extension [-Wc++11-extensions] cargo:warning= String(String &&) noexcept; cargo:warning= ^ cargo:warning=src/../include/cxx.h:40:20: error: expected ';' at end of declaration list cargo:warning= String(String &&) noexcept; cargo:warning= ^ cargo:warning= ; cargo:warning=src/../include/cxx.h:41:12: error: expected ';' at end of declaration list cargo:warning= ~String() noexcept; cargo:warning= ^ cargo:warning= ; cargo:warning=src/../include/cxx.h:50:43: error: expected ';' at end of declaration list cargo:warning= static String lossy(const std::string &) noexcept; cargo:warning= ^ cargo:warning= ; cargo:warning=src/../include/cxx.h:51:36: error: expected ';' at end of declaration list cargo:warning= static String lossy(const char *) noexcept; cargo:warning= ^ cargo:warning= ; cargo:warning=src/../include/cxx.h:52:49: error: expected ';' at end of declaration list cargo:warning= static String lossy(const char *, std::size_t) noexcept; cargo:warning= ^ cargo:warning= ; cargo:warning=src/../include/cxx.h:53:40: error: expected ';' at end of declaration list cargo:warning= static String lossy(const char16_t *) noexcept; cargo:warning= ^ cargo:warning= ; cargo:warning=src/../include/cxx.h:54:53: error: expected ';' at end of declaration list cargo:warning= static String lossy(const char16_t *, std::size_t) noexcept; cargo:warning= ^ cargo:warning= ; cargo:warning=src/../include/cxx.h:56:37: warning: reference qualifiers on functions are a C++11 extension [-Wc++11-extensions] cargo:warning= String &operator=(const String &) &noexcept; cargo:warning= ^ cargo:warning=src/../include/cxx.h:56:38: error: expected ';' at end of declaration list cargo:warning= String &operator=(const String &) &noexcept; cargo:warning= ^ cargo:warning= ; cargo:warning=src/../include/cxx.h:57:28: warning: rvalue references are a C++11 extension [-Wc++11-extensions] cargo:warning= String &operator=(String &&) &noexcept; cargo:warning= ^ cargo:warning=src/../include/cxx.h:57:32: warning: reference qualifiers on functions are a C++11 extension [-Wc++11-extensions] cargo:warning= String &operator=(String &&) &noexcept; cargo:warning= ^ cargo:warning=src/../include/cxx.h:57:33: error: expected ';' at end of declaration list cargo:warning= String &operator=(String &&) &noexcept; cargo:warning= ^ cargo:warning= ; cargo:warning=src/../include/cxx.h:59:3: warning: explicit conversion functions are a C++11 extension [-Wc++11-extensions] cargo:warning= explicit operator std::string() const; cargo:warning= ^~~~~~~~ cargo:warning=src/../include/cxx.h:62:27: error: expected ';' at end of declaration list cargo:warning= const char *data() const noexcept; cargo:warning= ^ cargo:warning= ; cargo:warning=src/../include/cxx.h:63:27: error: expected ';' at end of declaration list cargo:warning= std::size_t size() const noexcept; cargo:warning=

Check warning on line 17 in Formula/risingwave.rb

View workflow job for this annotation

GitHub Actions / test-bot (ubuntu-22.04)

`brew install --verbose --build-bottle risingwavelabs/risingwave/risingwave` failed on Linux!

Compiling madsim-tokio v0.2.23 Compiling semver v1.0.18 Compiling sct v0.7.0 Compiling crossbeam-utils v0.8.16 Compiling aho-corasick v1.0.4 Compiling zeroize_derive v1.4.2 Compiling rustls v0.21.6 Compiling regex-syntax v0.7.5 Compiling regex-automata v0.3.7 Compiling rustc_version v0.4.0 Compiling num-bigint v0.4.3 Compiling bitflags v1.3.2 Compiling regex v1.9.4 Compiling prost-derive v0.11.9 Compiling pin-project v1.1.3 Compiling bitflags v2.4.0 Compiling rustls-pemfile v1.0.3 Compiling form_urlencoded v1.2.0 Compiling libz-sys v1.1.12 Compiling deranged v0.3.7 Compiling subtle v2.5.0 Compiling const-oid v0.9.5 Compiling num_threads v0.1.6 Compiling time v0.3.28 Compiling lazy_static v1.4.0 Compiling crypto-common v0.1.6 Compiling block-buffer v0.10.4 Compiling digest v0.10.7 Compiling byteorder v1.4.3 Compiling strsim v0.10.0 Compiling tokio-stream v0.1.14 (https://github.com/madsim-rs/tokio.git?rev=fe39bb8e#fe39bb8e) Compiling uncased v0.9.9 Compiling rustls v0.20.8 Compiling openssl-probe v0.1.5 Compiling cpufeatures v0.2.9 Compiling foreign-types-shared v0.1.1 Compiling ident_case v1.0.1 Compiling foreign-types v0.3.2 Compiling tinyvec_macros v0.1.1 Compiling tower-layer v0.3.2 Compiling tinyvec v1.6.0 Compiling unicode-normalization v0.1.22 Compiling rustls-webpki v0.101.4 Compiling unicode-bidi v0.3.13 Compiling mime v0.3.17 Compiling tower v0.4.13 Compiling zeroize v1.6.0 Compiling axum-core v0.3.4 Compiling webpki v0.22.0 Compiling tokio-rustls v0.24.1 Compiling tokio-native-tls v0.3.1 Compiling time v0.1.45 Compiling iana-time-zone v0.1.57 Compiling static_assertions v1.1.0 Compiling chrono v0.4.26 Compiling sha2 v0.10.7 Compiling rustls-native-certs v0.6.3 Compiling serde_urlencoded v0.7.1 Compiling hyper-tls v0.5.0 Compiling prost v0.11.9 Compiling aws-types v0.55.3 Compiling memoffset v0.9.0 Compiling os_pipe v1.1.4 Compiling shared_child v1.0.0 Compiling duct v0.13.6 Compiling async-stream-impl v0.3.5 Compiling io-lifetimes v1.0.11 Compiling outref v0.5.1 Compiling vsimd v0.8.0 Compiling base64-simd v0.8.0 Compiling hmac v0.12.1 Compiling futures-executor v0.3.28 Compiling multimap v0.8.3 Compiling aws-smithy-types v0.55.3 Compiling postgres-derive v0.4.5 Compiling crossbeam-epoch v0.9.15 Compiling flate2 v1.0.26 Compiling crossbeam-channel v0.5.8 Compiling fastrand v1.9.0 Compiling idna v0.4.0 Compiling serde_path_to_error v0.1.14 Compiling cmake v0.1.50 Compiling siphasher v0.3.10 Compiling hex v0.4.3 Compiling rustix v0.36.15 Compiling phf_shared v0.11.2 Compiling url v2.4.1 Compiling aws-smithy-eventstream v0.55.3 Compiling bytes-utils v0.1.3 Compiling aws-smithy-http v0.55.3 Compiling lexical-util v0.8.5 Compiling crc32c v0.6.4 Compiling axum v0.6.20 Compiling memoffset v0.7.1 Compiling winnow v0.5.10 Compiling toml_datetime v0.6.3 Compiling rust_decimal v1.31.0 Compiling toml_edit v0.19.14 Compiling darling_core v0.20.3 Compiling md-5 v0.10.5 Compiling rustls-webpki v0.100.2 Compiling tokio-io-timeout v1.2.0 Compiling num-iter v0.1.43 Compiling sync_wrapper v0.1.2 Compiling matchit v0.7.2 Compiling protobuf v2.28.0 Compiling procfs v0.14.2 Compiling darling_macro v0.20.3 Compiling hyper-timeout v0.4.1 Compiling webpki-roots v0.23.1 Compiling proc-macro-crate v1.3.1 Compiling tokio-rustls v0.23.4 Compiling aws-smithy-async v0.55.3 Compiling phf v0.11.2 Compiling futures v0.3.28 Compiling async-stream v0.3.5 Compiling urlencoding v2.1.3 Compiling rustix v0.38.8 Compiling minimal-lexical v0.2.1 Compiling nom v7.1.3 Compiling tonic v0.9.2 Compiling hyper-rustls v0.23.2 Compiling num_enum_derive v0.5.11 Compiling darling v0.20.3 Compiling lexical-write-integer v0.8.5 Compiling lexical-parse-integer v0.8.6 Compiling aws-smithy-htt
# this will install the necessary cargo/rustup toolchain bits in HOMEBREW_CACHE
system "#{Formula["rustup-init"].bin}/rustup-init",
"-qy", "--no-modify-path",
Expand All @@ -28,6 +22,13 @@
ENV.prepend_path "PATH", HOMEBREW_CACHE/"cargo_cache/bin"

ENV.delete "RUSTFLAGS" # https://github.com/Homebrew/brew/pull/15544#issuecomment-1628639703
# Homebrew changes cxx flags, and CMake doesn't pick them up, so rdkafka-sys build fails.
# We cannot pass CMake flags (`std_cmake_args`) because it's in their build.rs.
#
# Some refs that might be useful:
# https://github.com/Homebrew/homebrew-core/pull/51949#issuecomment-601943075
# https://github.com/Homebrew/brew/pull/7134
ENV["SDKROOT"] = MacOS.sdk_path_if_needed
system "cargo", "install",
"--bin", "risingwave",
"--features", "rw-static-link",
Expand Down
4 changes: 4 additions & 0 deletions test_locally.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#!/bin/sh

brew uninstall risingwave
brew install -v --build-from-source --HEAD Formula/risingwave.rb
Loading