-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support write #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the link to upstream PR and what's the status? 👀
I have add more context about this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Since risingwavelabs/risingwave#19887 passes all iceberg tests. I think it is ok to move fast to migrate from icelake to iceberg-rust.
This PR:
feat: support
arrow_struct_to_iceberg_struct
apache/iceberg-rust#731This PR is implemented in different ways, compared to Upstream. I'm not sure which direction of upstream go so we just pick one now following icelake now. (Serialize it into json). I think after upstream pr merged, we can change it to avro.
However, as feat: support to append delete type data file apache/iceberg-rust#798 (comment) says, we need more work to do this. For now it just compatible with icelake.