Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: cherry-pick 67d434d #12

Draft
wants to merge 2 commits into
base: rw_rebase_main_20241129
Choose a base branch
from
Draft

Conversation

Li0k
Copy link

@Li0k Li0k commented Dec 27, 2024

cherry-pick

#7

Prioritize upstream commits and bring them into the rw repo after upstream merge.

* suppport remove all for file io

* resolve conflict

* reorder record batch

* fix scan

* fix filtered_entries

* fix ci ut

* change list item name back to list element

* fix

* feat(iceberg): support sql catalog interface

* typo

* chore(cargo): Downgrading sqlx from 0.8.0 to 0.7.3

* fix(iceberg): remove namespace_exists for sql catalogs

* fix(iceberg): fix set snapshot ref

* feat(iceberg): introduce disable_config_load for storage_s3

* chore(cargo): upgrade sqlx from 0.7.3 to 0.7.4

---------

Co-authored-by: Dylan Chen <[email protected]>
Co-authored-by: xxhZs <[email protected]>
Co-authored-by: Xinhao Xu <[email protected]>
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not submit to upstream directly? 👀 As we can see part of #7 is implemented now

@Li0k
Copy link
Author

Li0k commented Dec 30, 2024

Why not submit to upstream directly? 👀 As we can see part of #7 is implemented now

What you mentioned is exactly what I want to do. Currently, the diff between cherry-pick and the upstream is update_tables. I expect to commit the update_table to upstream and then bring it into our repo.

@Li0k
Copy link
Author

Li0k commented Dec 31, 2024

apache#862

@Li0k
Copy link
Author

Li0k commented Jan 2, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants