Skip to content

Commit

Permalink
change node label RPC
Browse files Browse the repository at this point in the history
  • Loading branch information
CAJan93 committed Jun 6, 2024
1 parent 497339a commit 45c7fc8
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 0 deletions.
5 changes: 5 additions & 0 deletions proto/catalog.proto
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,11 @@ message Table {
// tables and tests. Not to be confused with the global catalog version for
// notification service.
TableVersion version = 100;

// If a table/MV has a node_label, its actors can only be scheduled on CNs with
// that label. If a table/MV does not have a node_label it can be scheduled on any
// CN without a label,
optional string node_label = 101;
}

enum HandleConflictBehavior {
Expand Down
15 changes: 15 additions & 0 deletions proto/meta.proto
Original file line number Diff line number Diff line change
Expand Up @@ -566,12 +566,27 @@ message GetReschedulePlanResponse {
bool success = 3;
}

message ChangeMvNodeLabelRequest {
// Id of the MV which label we want to change
// contains IDs from catalog.Table.id
uint32 mv_id = 1;

// The new label value. If set should be a UUID
// If omitted, the node_label of the MV is removed
// meta can schedule MVs without label on any CN without a label (default behavior)
optional string new_label = 2;
}

// We do not need to add an explicit status field here, we can just use the RPC status
message ChangeMvNodeLabelResponse {}

service ScaleService {
// For the first version we will use busy wait and just repeatably send GetClusterInfoRequest
// rpc SubscribeClusterInfo(GetClusterInfoRequest) returns (stream GetClusterInfoResponse);
rpc GetClusterInfo(GetClusterInfoRequest) returns (GetClusterInfoResponse);
rpc Reschedule(RescheduleRequest) returns (RescheduleResponse);
rpc GetReschedulePlan(GetReschedulePlanRequest) returns (GetReschedulePlanResponse);
rpc ChangeMvNodeLabel(ChangeMvNodeLabelRequest) return (ChangeMvNodeLabelResponse);

Check failure on line 589 in proto/meta.proto

View workflow job for this annotation

GitHub Actions / Check breaking changes in Protobuf files

syntax error: unexpected identifier, expecting "returns"
}

message MembersRequest {}
Expand Down

0 comments on commit 45c7fc8

Please sign in to comment.