fix

risingwavelabs · Apr 9, 2024 · 4605ae0 · 4605ae0
1 parent 693d8b1
commit 4605ae0
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 24 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/src/connector/src/sink/big_query.rs b/src/connector/src/sink/big_query.rs
@@ -366,7 +366,7 @@ impl BigQuerySinkWriter {
                     &config.common.table
                 ))
             })?;
-        let row_encoder = ProtoEncoder::new_with_bigquery(
+        let row_encoder = ProtoEncoder::new(
             schema.clone(),
             None,
             message_descriptor.clone(),

diff --git a/src/connector/src/sink/encoder/proto.rs b/src/connector/src/sink/encoder/proto.rs
@@ -74,24 +74,6 @@ impl ProtoEncoder {
             header,
         })
     }
-
-    pub fn new_with_default(
-        schema: Schema,
-        col_indices: Option<Vec<usize>>,
-        descriptor: MessageDescriptor,
-        header: ProtoHeader,
-    ) -> SinkResult<Self> {
-        Self::new(schema, col_indices, descriptor, header)
-    }
-
-    pub fn new_with_bigquery(
-        schema: Schema,
-        col_indices: Option<Vec<usize>>,
-        descriptor: MessageDescriptor,
-        header: ProtoHeader,
-    ) -> SinkResult<Self> {
-        Self::new(schema, col_indices, descriptor, header)
-    }
 }
 
 pub struct ProtoEncoded {
@@ -499,8 +481,7 @@ mod tests {
         ]);
 
         let encoder =
-            ProtoEncoder::new_with_default(schema, None, descriptor.clone(), ProtoHeader::None)
-                .unwrap();
+            ProtoEncoder::new(schema, None, descriptor.clone(), ProtoHeader::None).unwrap();
         let m = encoder.encode(row).unwrap();
         let encoded: Vec<u8> = m.ser_to().unwrap();
         assert_eq!(

diff --git a/src/connector/src/sink/formatter/mod.rs b/src/connector/src/sink/formatter/mod.rs
@@ -134,8 +134,7 @@ impl SinkFormatterImpl {
                             None => ProtoHeader::None,
                             Some(sid) => ProtoHeader::ConfluentSchemaRegistry(sid),
                         };
-                        let val_encoder =
-                            ProtoEncoder::new_with_default(schema, None, descriptor, header)?;
+                        let val_encoder = ProtoEncoder::new(schema, None, descriptor, header)?;
                         let formatter = AppendOnlyFormatter::new(key_encoder, val_encoder);
                         Ok(SinkFormatterImpl::AppendOnlyProto(formatter))
                     }