Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(lru): use sequence-based eviction policy instead of epoch-based #15928

Closed
wants to merge 11 commits into from

Conversation

MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Mar 26, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@MrCroxx
Copy link
Contributor Author

MrCroxx commented Apr 2, 2024

The memory control looks much better, but the use of the global atomic access brings too much overhead that harms the performance. I'll send another PR to try another method.

@MrCroxx MrCroxx closed this Apr 2, 2024
@MrCroxx
Copy link
Contributor Author

MrCroxx commented Apr 2, 2024

A macro bench on atomic ops: https://gist.github.com/MrCroxx/20b3fe56d8fbd9ed57d735be5be48909

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant