Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sink): support redis cluster url #16034

Merged
merged 6 commits into from
Apr 9, 2024
Merged

feat(sink): support redis cluster url #16034

merged 6 commits into from
Apr 9, 2024

Conversation

xxhZs
Copy link
Contributor

@xxhZs xxhZs commented Apr 1, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

#15622

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

we support redis cluster url.
If redis is a cluster, we need use json array , like
redis.url= '["redis://redis-server:6379/","redis://redis-server:6380/","redis://redis-server:6381/]'

if redis is not a cluster,we need use string like (Same way as before.)
redis.url= 'redis://redis-server:6379/'

save

fix ci
@xxhZs xxhZs requested a review from a team as a code owner April 1, 2024 07:24
@xxhZs xxhZs added user-facing-changes Contains changes that are visible to users ci/run-e2e-redis-sink-tests and removed type/feature labels Apr 1, 2024
@xxhZs xxhZs requested review from wenym1 and hzxa21 April 1, 2024 09:01
@yuhao-su
Copy link
Contributor

yuhao-su commented Apr 5, 2024

Do you think we need to start a redis cluster for running the e2e for cluster sink?

integration_tests/redis-sink/create_sink.sql Outdated Show resolved Hide resolved
src/connector/src/sink/redis.rs Show resolved Hide resolved
src/connector/src/sink/redis.rs Show resolved Hide resolved
Copy link
Contributor

@wenym1 wenym1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM!

Need to add more details on the release note part.

src/connector/src/sink/redis.rs Outdated Show resolved Hide resolved
src/connector/src/sink/redis.rs Show resolved Hide resolved
@xxhZs xxhZs force-pushed the xxh/support-redis-cluster branch from 3881de9 to caf8d28 Compare April 8, 2024 09:49
@xxhZs xxhZs enabled auto-merge April 8, 2024 10:12
@xxhZs xxhZs force-pushed the xxh/support-redis-cluster branch from a0b9f57 to cb834a0 Compare April 8, 2024 10:49
fix

fix ci

fix ci

fix ci
@xxhZs xxhZs force-pushed the xxh/support-redis-cluster branch from cb834a0 to 3926983 Compare April 8, 2024 11:04
@xxhZs xxhZs disabled auto-merge April 9, 2024 04:07
@xxhZs xxhZs enabled auto-merge April 9, 2024 04:07
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cargo.lock LGTM

@xxhZs xxhZs added this pull request to the merge queue Apr 9, 2024
Merged via the queue into main with commit bdcc939 Apr 9, 2024
31 of 32 checks passed
@xxhZs xxhZs deleted the xxh/support-redis-cluster branch April 9, 2024 10:09
@xxhZs xxhZs restored the xxh/support-redis-cluster branch April 10, 2024 04:30
xxhZs added a commit that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants