Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(diagnosis): Dump JVM stack trace in await-tree-dump #17254

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Jun 14, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Closes #17236

  • Get JVM stack traces via the Java function Monitor.dumpStackTrace()
  • BTW, improved an error message of connection failure in CDC connector

Screenshots

Web Dashboard:

image

risectl trace:

image

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 5122 files.

Valid Invalid Ignored Fixed
2188 1 2933 0
Click to see the invalid file list
  • java/connector-node/connector-api/src/main/java/com/risingwave/connector/api/Monitor.java

Copy link
Contributor

@wenym1 wenym1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@fuyufjh fuyufjh enabled auto-merge June 14, 2024 06:33
@fuyufjh fuyufjh added this pull request to the merge queue Jun 14, 2024
Merged via the queue into main with commit 39e79db Jun 14, 2024
31 of 32 checks passed
@fuyufjh fuyufjh deleted the eric/java_stack_dump branch June 14, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(diagnosis): Print stacktrace of JVM along with await tree dump
4 participants