Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sink): add clickhouse delete column for CollapsingMergeTree #17385

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

xxhZs
Copy link
Contributor

@xxhZs xxhZs commented Jun 21, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

#17283 add delete column. To ensure consistency in the syntax of upsert, we add it for CollapsingMergeTree.
and add upsert e2e test

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

It should be recommended in the document that users set delete.columns when using CollapsingMergeTree,
VersionedCollapsingMergeTree and upsert

@xxhZs xxhZs added the user-facing-changes Contains changes that are visible to users label Jun 21, 2024
@xxhZs xxhZs force-pushed the xxh/add-ck-del-col branch 5 times, most recently from fc8e201 to 60362ad Compare June 21, 2024 08:29
fix

fix

fix ci

fix

fix ci

fix
@xxhZs xxhZs requested a review from hzxa21 July 1, 2024 08:17
@graphite-app graphite-app bot requested a review from xxchan July 26, 2024 02:51
Copy link
Contributor

github-actions bot commented Oct 6, 2024

This PR has been open for 60 days with no activity.

If it's blocked by code review, feel free to ping a reviewer or ask someone else to review it.

If you think it is still relevant today, and have time to work on it in the near future, you can comment to update the status, or just manually remove the no-pr-activity label.

You can also confidently close this PR to keep our backlog clean. (If no further action taken, the PR will be automatically closed after 7 days. Sorry! 🙏)
Don't worry if you think the PR is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

@xxchan xxchan removed their request for review October 11, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant