Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(storage): remove legacy delta type GroupMetaChange and GroupTableChange #18585

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

Li0k
Copy link
Contributor

@Li0k Li0k commented Sep 18, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

as title, We've been deprecating these two types for a long time, and we're removing them in the next release.

Introduce proto #7817

Introduce logic #8390

deprecate proto #17125

remove proto and logic #18585

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

For future reference, can you also document in which version GroupMetaChange and GroupTableChange start to be deprecated? You can also include the PR link in the PR description.

@Li0k Li0k added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit ff479f6 Sep 18, 2024
36 of 37 checks passed
@Li0k Li0k deleted the li0k/storage_remove_legacy_delta_type branch September 18, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants