fix(meta): persist correct vnode count for table catalogs in sql backend #18759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @BugenZhao and the rest of your teammates on |
4 tasks
BugenZhao
force-pushed
the
bz/var-vnode-system-tables
branch
from
c2f007c to
7a83d1a
Compare
BugenZhao
force-pushed
the
bz/var-vnode-table-catalog-vnode-count
branch
from
61792a9 to
eb7d2cf
Compare
BugenZhao
force-pushed
the
bz/var-vnode-system-tables
branch
from
7a83d1a to
07ec687
Compare
BugenZhao
force-pushed
the
bz/var-vnode-table-catalog-vnode-count
branch
from
eb7d2cf to
beba88d
Compare
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
force-pushed
the
bz/var-vnode-table-catalog-vnode-count
branch
from
beba88d to
23a1d96
Compare
BugenZhao
changed the title
BugenZhao
changed the title
yezizp2012
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This is a progress towards #15900.
The table catalogs of internal tables are immediately persisted and broadcasted to other nodes when ids are allocated during the creation of a new streaming job. However, at that time we don't have scheduling info, i.e., the
vnode_countof each fragment (then internal tables) hasn't been determined yet. As a result, we failed to persist the correctvnode_countin table catalogs.In this PR, we fix this issue by updating that field in a separate step afterwards, together with other fields like
fragment_id. Note that this only fixes the implementation for the SQL backend, since the etcd backend will be deprecated very soon (in #18727), making it less worthwhile to invest effort in it.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.