fix: changelog does not support fully qualified path #18785
Merged
+14
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close issue risingwavelabs#18747 by using ObjectName for table instead of Ident. Signed-off-by: yihong0618 <[email protected]>
Signed-off-by: yihong0618 <[email protected]>
|
Thank you! Call for reviewers @xiangjinwu @tabVersion @xxhZs |
xiangjinwu
approved these changes
Oct 18, 2024
| f, | ||
| "{} AS changelog from {}", | ||
| self.alias, | ||
| obj_name.real_value() |
There was a problem hiding this comment.
Suggested change
| obj_name.real_value() | |
| obj_name |
| @@ -156,7 +156,7 @@ impl QueryRewriter<'_> { | |||
| match &mut cte_table.cte_inner { | |||
| risingwave_sqlparser::ast::CteInner::Query(query) => self.visit_query(query), | |||
| risingwave_sqlparser::ast::CteInner::ChangeLog(from) => { | |||
| *from = Ident::new_unchecked(self.to) | |||
| *from = ObjectName(vec![Ident::new_unchecked(self.to)]) | |||
There was a problem hiding this comment.
The original version was wrong. I will fix it separately.
Merged
via the queue into
risingwavelabs:main
with commit Oct 18, 2024
73a4bb9
29 of 30 checks passed
learned a lot, thanks |
9 tasks
xxhZs
added
need-cherry-pick-release-1.10
xxhZs
pushed a commit
that referenced
this pull request
Oct 24, 2024
Signed-off-by: yihong0618 <[email protected]>
9 tasks
xxhZs
pushed a commit
that referenced
this pull request
Oct 24, 2024
Signed-off-by: yihong0618 <[email protected]>
9 tasks
xxhZs
pushed a commit
that referenced
this pull request
Oct 24, 2024
Signed-off-by: yihong0618 <[email protected]>
9 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 24, 2024
…-2.1 (#19098) Signed-off-by: yihong0618 <[email protected]> Co-authored-by: yihong <[email protected]> Co-authored-by: xiangjinwu <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 24, 2024
…-2.0 (#19096) Signed-off-by: yihong0618 <[email protected]> Co-authored-by: yihong <[email protected]> Co-authored-by: xiangjinwu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close issue #18747 by using ObjectName for table instead of Ident.
As the doc https://docs.risingwave.com/docs/current/sql-as-changelog/
fromcase is the table name, I think its better and less effort changing for changing to solvethis problem.
pub enum CteInner { Query(Query), - ChangeLog(Ident), + ChangeLog(ObjectName), }Also change one test for this case.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.