Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce node label #19153

Merged
merged 12 commits into from
Nov 25, 2024
Merged

feat: introduce node label #19153

merged 12 commits into from
Nov 25, 2024

Commits on Nov 22, 2024

  1. tmp 

    Signed-off-by: Shanicky Chen <[email protected]>
    @shanicky
    shanicky committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    9b326d5 View commit details
    Browse the repository at this point in the history

  2. Add node_label placeholder in tests; reorder lines in migration mod… 

    … for consistency

Signed-off-by: Shanicky Chen <[email protected]>
    @shanicky
    shanicky committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    973a639 View commit details
    Browse the repository at this point in the history

  3. Add node_label field with default value "default" to standalone m… 

    …odule config settings

Signed-off-by: Shanicky Chen <[email protected]>
    @shanicky
    shanicky committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    73caf7d View commit details
    Browse the repository at this point in the history

  4. Move parallelism to WorkerNode.Property, update related structs and r… 

    …eferences

Signed-off-by: Shanicky Chen <[email protected]>
    @shanicky
    shanicky committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    05b3ddf View commit details
    Browse the repository at this point in the history

  5. Remove parallelism field from ActiveStreamingWorkerNodes struct initi… 

    …alization

Signed-off-by: Shanicky Chen <[email protected]>
    @shanicky
    shanicky committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    1ce6b6d View commit details
    Browse the repository at this point in the history

  6. Add DEFAULT_COMPUTE_NODE_LABEL & use in ComputeNodeOpts 

    Signed-off-by: Shanicky Chen <[email protected]>
    @shanicky
    shanicky committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    447feb0 View commit details
    Browse the repository at this point in the history

  7. Add WorkerType import, set type field to ComputeNode in WorkerNode te… 

    …st initializations

Signed-off-by: Shanicky Chen <[email protected]>
    @shanicky
    shanicky committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    73104db View commit details
    Browse the repository at this point in the history

  8. Refactor: Update MetaClient import and remove parallelism setting in … 

    …AddWorkerNodeRequest

Signed-off-by: Shanicky Chen <[email protected]>
    @shanicky
    shanicky committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    41b7b63 View commit details
    Browse the repository at this point in the history

  9. Rename 'label' module to 'node_label' for clarity and update references 

    Signed-off-by: Shanicky Chen <[email protected]>
    @shanicky
    shanicky committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    f287642 View commit details
    Browse the repository at this point in the history

  10. Remove parallelism, reorder fields, update tests, modify worker node … 

    …info function

Signed-off-by: Shanicky Chen <[email protected]>
    @shanicky
    shanicky committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    b61ed85 View commit details
    Browse the repository at this point in the history

  11. Remove 'label' migration, keeping 'node_label' in Migrator implementa… 

    …tion

Signed-off-by: Shanicky Chen <[email protected]>
    @shanicky
    shanicky committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    9fe686f View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Merge branch 'main' into peng/node-label

    @shanicky
    shanicky authored Nov 25, 2024
    Configuration menu
    Copy the full SHA
    54d1e45 View commit details
    Browse the repository at this point in the history