Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky slt test cases with retry #20018

Merged
merged 4 commits into from
Jan 6, 2025
Merged

test: fix flaky slt test cases with retry #20018

merged 4 commits into from
Jan 6, 2025

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Jan 3, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

See background in risinglightdb/sqllogictest-rs#238.

Waiting for risinglightdb/sqllogictest-rs#244.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@fuyufjh fuyufjh requested a review from xxchan January 3, 2025 08:58
@fuyufjh fuyufjh marked this pull request as draft January 3, 2025 08:58
@github-actions github-actions bot added the component/test Test related issue. label Jan 3, 2025
@fuyufjh fuyufjh marked this pull request as ready for review January 6, 2025 07:00
@fuyufjh fuyufjh force-pushed the eric/add_retry_to_some_e2e branch from c0f57dc to 7ea9306 Compare January 6, 2025 07:00
@fuyufjh fuyufjh requested a review from a team as a code owner January 6, 2025 07:00
@fuyufjh fuyufjh added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit fef0ffe Jan 6, 2025
30 of 31 checks passed
@fuyufjh fuyufjh deleted the eric/add_retry_to_some_e2e branch January 6, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxchan xxchan xxchan approved these changes

Assignees
No one assigned
Labels
component/test Test related issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fuyufjh @xxchan