New example file for the midi-player with 2 players #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Second song for second player
Interface changed: - No need for having an extra link for loading the song when it's time to play it - This function (loadScore) is passed to MyPlayerClass constructor - It's the 'play' button of the player that starts the MyPlayerClass play method
|
Interface changed:
|
|
Note that the example must now be run from a web server, as browsers don't accept that local resources (here wildwebmidi.data) are pulled with file protocol (only HTTP) : CORS error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new song file was added (example-song2.js)
There are 2 separate divs for the 2 players.
Two separate instances of the MidiPlayerClass are created, each of them getting the div id as parameter + an additional list of options allowing to change the progress bar color for example.
Although this interface is not compatible with the previous code, it was kept as close as possible to the former one.
BR