Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MusicXML ties resolved to have an ending note coming before its starting note #3538

Merged
merged 2 commits into from
Oct 21, 2023
Merged

Fix MusicXML ties resolved to have an ending note coming before its starting note #3538

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33ac21f
Fix MusicXML ties ending before the starting notes
paxbun Oct 20, 2023
6ade359
Merge branch 'rism-digital:develop' into fix/musicxml-backward-ties
paxbun Oct 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/iomusxml.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1708,6 +1708,9 @@ bool MusicXmlInput::ReadMusicXmlMeasure(

this->MatchTies(true);
if (!m_tieStack.empty()) this->MatchTies(false);
for (auto openTie : m_tieStack) {
openTie.m_note->SetScoreTimeOnset(-1); // make scoreTimeOnset small for next measure
}

// clear stop stacks after each measure
m_hairpinStopStack.clear();
Expand Down Expand Up @@ -1764,7 +1767,6 @@ void MusicXmlInput::MatchTies(bool matchLayers)
m_tieStopStack.erase(jter);
}
else {
iter->m_note->SetScoreTimeOnset(-1); // make scoreTimeOnset small for next measure
++iter;
}
}
Expand Down