Add initial support for <annot type="score"> (classes and round trip read/write) #3896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpugin
reviewed
Dec 17, 2024
src/iomei.cpp
Outdated
Comment on lines
7695
to
7719
| AnnotScore *vrvAnnotScore = new AnnotScore(); | ||
| // this->ReadEditorialElement(annot, vrvAnnotScore); | ||
|
|
||
| vrvAnnotScore->ReadPlist(annot); | ||
| // vrvAnnotScore->ReadSource(annot); | ||
|
|
||
| parent->AddChild(vrvAnnotScore); | ||
| // vrvAnnotScore->m_content.reset(); | ||
|
|
||
| bool hasNonTextContent = false; | ||
| // copy all the nodes inside into the document | ||
| for (pugi::xml_node child = annot.first_child(); child; child = child.next_sibling()) { | ||
| const std::string nodeName = child.name(); | ||
| if (!hasNonTextContent && (!nodeName.empty())) hasNonTextContent = true; | ||
| // vrvAnnotScore->m_content.append_copy(child); | ||
| } | ||
| this->ReadUnsupportedAttr(annot, vrvAnnotScore); | ||
| // Unless annot has only text we do not load children because they are preserved in Annot::m_content | ||
| if (hasNonTextContent) { | ||
| return true; | ||
| } | ||
| else { | ||
| // vrvAnnot->m_content.remove_children(); | ||
| return this->ReadTextChildren(vrvAnnotScore, annot, vrvAnnotScore); | ||
| } |
There was a problem hiding this comment.
Keep only what you use now and remove the commented code. We can easily put things back whenever needed.
There was a problem hiding this comment.
I've taken cancelled code out of here, but left a few comments to remind myself what's gone
Co-authored-by: Laurent Pugin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class definitions, etc for a new type of annotation, 'annotScore', for annotations that we might want to appear in a score application. This PR also includes functionality for reading and writing (hopefully) transparently.
I'm putting some examples to test into this repo