Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullstack app #86

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Fullstack app #86

wants to merge 17 commits into from

Conversation

gary-rivera
Copy link
Collaborator

This pull request includes a

  • Bug fix
  • New feature
  • New number fact
  • [ x ] Translation

The following changes were made

- Refactored front-end from jQuery to React

#53

@Nalipp
Copy link
Contributor

Nalipp commented May 19, 2021

The font looks different on the React app and the original site.
Here are some of the css variables that may need to be added globally.

    text-shadow: #000000 0px 1px 0px;
    font-family: Palatino, Georgia, serif;
    font-weight: normal;
    color: #cce4f4;

You can add global styles to the index.css file just like you did with the @font-face.

Copy link
Contributor

@Nalipp Nalipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a problem with the way the new react site renders on mobile devices.
We don't have to make the site responsive to mobile (maybe a future feature) but before we can merge we need to fix.

old site on mobile

old-site

new site on mobile
new-site

frontend/src/Sandbox/Counter.css Outdated Show resolved Hide resolved
frontend/src/Sandbox/Counter.css Show resolved Hide resolved
@Nalipp
Copy link
Contributor

Nalipp commented May 19, 2021

The line breaks seem to be missing.
Screen Shot 2021-05-19 at 2 34 36 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants