Set always_increment_patch_version: true #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this setting, every PR (or merge) to the trunk branch will automatically bump the patch version and publish a new release tag. The underlying workflows/actions have been updated to actually publish to the npmjs.org registry.
|
I just want to make sure that this is indeed what we want on a package that actually publishes to npm? |
|
@jaime-lynn what are your concerns? |
|
I have zero issues if that's what we want to do! Just wanted to double check because it does mean that we won't really get a QA period before throwing the update out into the universe. |
hougasian
approved these changes
Sep 7, 2023
|
We do not, but we really don't now either. We just push multiple patches until the thing works. |
schilco-rimdev
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this setting, every PR (or merge) to the trunk branch will automatically bump the patch version and publish a new release tag.
The underlying workflows/actions (v1.3.0) have been updated to actually publish to the npmjs.org registry.
Example: Even without adding the "+semver:patch" label to this PR, the patch version is bumped.