Skip to content

Commit

Permalink
Avoid initializing an AudioEngine instance if there is no audio present
Browse files Browse the repository at this point in the history
Community PR from AOFL: #431

I'm co-authoring to get it in

Slack discussion: https://2dimensions.slack.com/archives/C073BQNPQ5T/p1731028216451459

We will need to look into the actual fix. I'm not that familiar with our Audio system, and not sure if there are edge cases to consider with this change.

Diffs=
aea593c2df Avoid initializing an AudioEngine instance if there is no audio present (#8541)
3a638e61b1 Work around Galaxy S22 compiler bugs (#8549)
01bc166a8e invert order of advance between parent and child (#8547)
26d8b495b6 Prevent NestedArtboard advance when not playing (#8542)
ded183b39c Rhi typeless uav support (#8507)
6804948c90 new arithmetic data converter that uses a viewmodel as input (#8536)
532ca5dfb3 Unreal build use build rive.sh (#8502)
692dc6f659 default data converters runtime (#8503)
9aa4503c18 LayoutComponent updates properly when scaleType changes (#8535)
46b0899967 fix data enum importer (#8531)
4bbd7d495c Fix marking nested artboard layout dirty (#8534)
fa4f11f061 add feather property (#8533)
97050e4fa7 Pass scaleType down to sizeable children (#8524)
071b19ba62 don't expose yoga includes (#8526)
ad1ca22bd5 Nnnn render update fixes (#8527)
8826406ff1 editor and runtime: fix vector n-slicer hit area (#8512)
98e6822f02 Rename "atlas" -> "coverage" in the clockwise shader (#8518)
01066ff6a0 Fix bidi (#8517)
8296d87711 conditionnally  add dirt and advance (#8516)
8738368345 Updates to AdvanceFlags (#8514)
17cbda4b69 Add AdvanceFlags (#8492)
6cb69b688b Fix for layout shape paint bug (#8498)
33dc66a73e editor and runtime: allow vertices in a vector nslicer to be out of bounds (#8495)
cba259e6cd add data bind support for vertex properties (#8494)
f4c87ee495 Nnnn merge fills and strokes (#8465)
af9e217d23 Use renderImage size to scale images in layouts (#8487)
ce9e44c6b3 editor: NSlicer should not clamp children (#8459)
446682cda9 web: decode image on demand, not render (#8484)

Co-authored-by: Anurag Devanapally <[email protected]>
Co-authored-by: Gordon <[email protected]>
  • Loading branch information
3 people committed Nov 13, 2024
1 parent b3898a9 commit 5495a00
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .rive_head
Original file line number Diff line number Diff line change
@@ -1 +1 @@
aa20d8aad42d5c832b6c96dfdce2b57bae18fdf9
aea593c2dfdc4eae136ea9aa7fd16ccb305c4854
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.13.16

- Avoid audio init on empty assets. See PR [431](https://github.com/rive-app/rive-flutter/pull/431).

## 0.13.15

- Fix audio crashing iOS
Expand Down
2 changes: 1 addition & 1 deletion example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ publish_to: "none" # Remove this line if you wish to publish to pub.dev
version: 1.0.0+1

environment:
sdk: ">=2.17.0 <3.0.0"
sdk: ">=2.17.0 <4.0.0"

dependencies:
flutter:
Expand Down
2 changes: 1 addition & 1 deletion lib/src/rive_core/state_machine_controller.dart
Original file line number Diff line number Diff line change
Expand Up @@ -640,7 +640,7 @@ class StateMachineController extends RiveAnimationController<CoreContext>
var riveEvents = <RiveEvent>[];

for (final event in events) {
if (event is AudioEvent) {
if (event is AudioEvent && event.asset != null) {
event.play(audioPlayer);
}
riveEvents.add(RiveEvent.fromCoreEvent(event));
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: rive
version: 0.13.15
version: 0.13.16
homepage: https://rive.app
description: Rive Flutter Runtime. This package provides runtime functionality for playing back and interacting with animations built with the Rive editor available at https://rive.app.
repository: https://github.com/rive-app/rive-flutter
Expand Down

0 comments on commit 5495a00

Please sign in to comment.