Patch invalid texture size crash #344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghugues
force-pushed
the
patch-invalid-texture-size
branch
from
d1b958c to
ea5634f
Compare
|
Thanks for your feedback! This has been addressed in the latest v6.2.1 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix for #343
This fix does not address the fact that we could receive drawing requests with a very big drawable size in situations where it's not needed. A proper fix would probably be to either find a way to fix the computation of the drawable size, or disable automatic computation (
autoResizeDrawable = NO) and compute it manually by converting the metal view bounds to window coordinates.