feat(core): configure actor region

[NathanFlurry]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
rivetkit-serverless	Ready	Preview	Comment	Oct 13, 2025 10:30pm

[NathanFlurry]

• feat(core): configure actor region #1384 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• merge queue - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

Claude finished @NathanFlurry's task —— View job

---

Code Review Complete

Reviewing PR #1384: feat(core): configure actor region

Todo List:

• Read repository guidelines (CLAUDE.md)
• Analyze changed files for code quality and best practices
• Check for potential bugs or issues
• Review performance considerations
• Examine security concerns
• Assess test coverage needs
• Provide comprehensive feedback

Summary

This PR introduces region configuration support for actors in RivetKit. The changes span three files and add the foundation for specifying datacenter regions when creating actors.

Code Quality & Best Practices ✅

The code follows established patterns and conventions:

• Proper use of zod schemas for API validation
• Consistent parameter naming (datacenter vs region)
• Follows existing code style and structure
• Optional parameters appropriately marked in schemas

Issues & Concerns 🔍

1. Hardcoded Region Value (actor-driver.ts:276)

"unknown", // TODO: Add regions

Issue: The region is hardcoded as "unknown" with a TODO comment, indicating incomplete implementation.
Impact: Actors won't have proper region information for routing/placement decisions.
Recommendation: Either implement proper region detection or use a configuration-based approach.

2. Parameter Name Inconsistency

• API schemas use datacenter: z.string().optional()
• Method signatures use region parameter
• Recommendation: Standardize on one term throughout the codebase for consistency.

3. Missing Validation in remote-manager-driver/mod.ts

The region parameter is passed directly to API calls without validation:

const { actor, created } = await getOrCreateActor(this.#config, {
    datacenter: region, // No validation that region is a valid datacenter
    // ...
});

Performance Considerations ⚡

• Positive: Changes are minimal and don't introduce performance overhead
• Neutral: Optional parameters won't impact existing functionality
• Note: Region-based routing could improve performance when properly implemented

Security Concerns 🔒

• Low Risk: The region parameter appears to be used for placement decisions rather than access control
• Recommendation: Ensure region values are validated against a whitelist of allowed datacenters to prevent injection or misrouting

Test Coverage 📋

Missing Tests: No tests were added for the new region functionality. Consider adding:

• Unit tests for API schema validation with/without datacenter parameter
• Integration tests verifying region parameter is properly passed through the call chain
• Tests for invalid region values (once validation is implemented)

Recommendations

1. Complete the Implementation: Replace the hardcoded "unknown" region with actual region detection logic
2. Add Input Validation: Validate region values against allowed datacenters
3. Standardize Naming: Use either "datacenter" or "region" consistently throughout
4. Add Tests: Include test coverage for the new functionality
5. Documentation: Consider adding JSDoc comments explaining the region parameter usage

Overall Assessment

This is a solid foundation for region support with clean, minimal changes. The main concern is the incomplete implementation (hardcoded "unknown" region). The changes follow established patterns but need completion and test coverage to be production-ready.

Recommendation: ✅ Approve with requested changes to complete the implementation.

---

[pkg-pr-new]

More templates

• example-ai-agent
• example-better-auth-external-db
• chat-room
• example-cloudflare-workers
• example-cloudflare-workers-hono
• example-counter
• example-counter-serverless
• example-crdt
• example-database
• example-deno
• example-sqlite
• example-elysia
• example-express
• example-freestyle
• example-game
• example-hono
• example-hono-bun
• example-hono-react
• example-kitchen-sink
• example-next-js
• example-rate
• example-raw-fetch-handler
• example-raw-websocket-handler
• example-raw-websocket-handler-proxy
• example-react
• example-smoke-test
• starter
• example-stream
• example-sync
• example-tenant
• example-trpc

@rivetkit/actor

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/actor@1384

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/cloudflare-workers@1384

@rivetkit/core

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/core@1384

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/db@1384

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/framework-base@1384

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/next-js@1384

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/react@1384

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivetkit@1384

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/sql-loader@1384

commit: 8f050e5