This repository was archived by the owner on Oct 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 44
feat: broadcastWithOptions ACTR-136 #939
Open
abcxff
wants to merge
1
commit into
04-20-feat_ai-agent_example
Choose a base branch
from
04-22-feat_broadcastwithoptions_actr-136
base: 04-20-feat_ai-agent_example
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -36,6 +36,16 @@ export interface SaveStateOptions { | |||||
immediate?: boolean; | ||||||
} | ||||||
|
||||||
/** | ||||||
* Options for the `_broadcastWithOptions` method. | ||||||
*/ | ||||||
export interface BroadcastInstanceOptions { | ||||||
/** | ||||||
* The connection IDs to be excluded from the broadcast. | ||||||
*/ | ||||||
exclude?: string[]; | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The type for
Suggested change
Spotted by Diamond |
||||||
} | ||||||
|
||||||
/** Actor type alias with all `any` types. Used for `extends` in classes referencing this actor. */ | ||||||
// biome-ignore lint/suspicious/noExplicitAny: Needs to be used in `extends` | ||||||
export type AnyActorInstance = ActorInstance<any, any, any, any>; | ||||||
|
@@ -1013,6 +1023,16 @@ export class ActorInstance<S, CP, CS, V> { | |||||
* @param args - The arguments to send with the event. | ||||||
*/ | ||||||
_broadcast<Args extends Array<unknown>>(name: string, ...args: Args) { | ||||||
return this._broadcastWithOptions({}, name, ...args); | ||||||
} | ||||||
|
||||||
/** | ||||||
* Broadcasts an event to all connected clients with options. | ||||||
* @param opts - Options for the broadcast. | ||||||
* @param name - The name of the event. | ||||||
* @param args - The arguments to send with the event. | ||||||
*/ | ||||||
_broadcastWithOptions<Args extends Array<unknown>>(opts: BroadcastInstanceOptions, name: string, ...args: Args) { | ||||||
this.#assertReady(); | ||||||
|
||||||
// Send to all connected clients | ||||||
|
@@ -1028,8 +1048,14 @@ export class ActorInstance<S, CP, CS, V> { | |||||
}, | ||||||
}); | ||||||
|
||||||
const excludeList = opts.exclude ?? []; | ||||||
|
||||||
// Send message to clients | ||||||
for (const connection of subscriptions) { | ||||||
if (excludeList.includes(connection.id)) { | ||||||
continue; | ||||||
} | ||||||
|
||||||
connection._sendMessage(toClientSerializer); | ||||||
} | ||||||
} | ||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential Issue: This code mutates the
exclude
array that was passed in throughopts
. If the caller reuses this array elsewhere, they might encounter unexpected behavior. Consider creating a copy of the array instead:This ensures the original array remains unchanged while still allowing the function to add the current connection ID when
excludeSelf
is true.Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.