chore(services/user): migrate user-team-list proto op #1650

ABCxFF · 2024-12-18T22:20:51Z

Changes

ABCxFF · 2024-12-18T22:21:08Z

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

cloudflare-workers-and-pages · 2024-12-18T22:25:24Z

Deploying rivet with Cloudflare Pages

Latest commit:	`2c153f0`
Status:	✅ Deploy successful!
Preview URL:	https://7f0d6cff.rivet.pages.dev
Branch Preview URL:	https://12-18-chore-services-user-mi-7ha2.rivet.pages.dev

View logs

MasterPtato

I know this is still in progress, just providing some initial feedback. Feel free to ignore any changes you've already made. Really good stuff all around.

I only have nits to add on top of the comments i left:

You can remove the leading :: from all user pkg paths (::user::ops::get -> user::ops::get)
Auto dereferencing should handle calls to .op in API services automatically, so you can change (*ctx) to just ctx
The migration files from api-identity were moved to the wrong location, the entire folder at packages/services/user-identity/db/user-identity should be moved to packages/services/user/db/user-identity
In the API layer we could change functions to accept an OperationCtx (new, from chirp-workflow) or a Ctx (from api-helper) instead of an OperationContext (old) which would allow us to get rid of compat calls and just do .op. This is low priority though and isn't required

MasterPtato · 2025-01-06T18:24:12Z

packages/api/cloud/src/auth.rs

+				team_ids: team_ids
+					.iter()
+					.map(|id| (*id).into())
+					.collect::<Vec<common::Uuid>>()


Nit: you can leave out the type in .collect statements if there is enough type info for the compiler to predict the type:

Suggested change

.collect::<Vec<common::Uuid>>()

.collect::<Vec<_>>()

or even

Suggested change

.collect::<Vec<common::Uuid>>()

.collect::<_>()

MasterPtato · 2025-01-06T18:28:10Z

packages/services/load-test/standalone/api-cloud/src/lib.rs

+		chirp_workflow::compat::op(
+			&ctx,
+			::user::ops::identity::create::Input {
+				user_id: primary_user_id,
+				identity: backend::user_identity::Identity {
+					kind: Some(backend::user_identity::identity::Kind::Email(backend::user_identity::identity::Email {
+						email: util::faker::email()
+					}))
+				}
+			}
+		)


Standalone services should be converted to use the new contexts as well, that way you dont have to use compat. See cluster-gc for an example. You'll have to change the ctx variable above to use StandaloneCtx

MasterPtato · 2025-01-06T18:28:29Z

packages/services/load-test/standalone/watch-requests/src/lib.rs

+		chirp_workflow::compat::op(
+			&ctx,
+			::user::ops::identity::create::Input {
+				user_id: primary_user_id,
+				identity: backend::user_identity::Identity {
+					kind: Some(backend::user_identity::identity::Kind::Email(backend::user_identity::identity::Email {
+						email: util::faker::email()
+					}))
+				}
+			}
+		)


See above comment

MasterPtato · 2025-01-06T18:31:10Z

packages/services/user/src/ops/get.rs

+
+#[derive(Debug)]
+pub struct Output {
+    pub users: Vec<backend::user::User>


The User type should be converted from proto to rust. It looks like you already know the drill given the team_list op 👍

MasterPtato · 2025-01-06T18:31:37Z

packages/services/user/src/ops/identity/create.rs

+#[derive(Debug)]
+pub struct Input {
+    pub user_id: Uuid,
+    pub identity: backend::user_identity::Identity,


Type should be converted from proto to rust

MasterPtato · 2025-01-06T18:32:08Z

packages/services/user/src/ops/identity/get.rs

+#[derive(Debug)]
+pub struct User {
+    pub user_id: Uuid,
+    pub identities: Vec<backend::user_identity::Identity>


See above comment

MasterPtato · 2025-01-06T18:35:30Z

packages/services/user/src/ops/profile_validate.rs

+
+#[derive(Debug)]
+pub struct Output {
+    pub errors: Vec<common::ValidationError>,


Should be converted to rust type

MasterPtato · 2025-01-06T18:36:11Z

packages/services/user/src/ops/token_create.rs

+#[derive(Debug)]
+pub struct Input {
+	pub user_id: Uuid,
+	pub client: backend::net::ClientInfo,


Should be converted to rust type

MasterPtato · 2025-01-06T18:38:36Z

packages/services/user/tests/token_create.rs

+
+	let res = ctx.op(::user::ops::token_create::Input {
+		user_id: user_id,
+		client: backend::net::ClientInfo {..Default::default()}


Suggested change

client: backend::net::ClientInfo {..Default::default()}

client: backend::net::ClientInfo::default()

ABCxFF force-pushed the 12-18-chore_services_user_migrate_user_proto_ops branch from 06909a8 to 4c41e8e Compare December 21, 2024 00:45

ABCxFF force-pushed the 12-18-chore_services_user_migrate_user_proto_ops branch from 4c41e8e to 075a092 Compare December 30, 2024 23:07

MasterPtato requested changes Jan 6, 2025

View reviewed changes

ABCxFF force-pushed the 12-18-chore_services_user_migrate_user_proto_ops branch from e508246 to ec88581 Compare January 7, 2025 15:45

ABCxFF mentioned this pull request Jan 7, 2025

chore(users): migrate proto backend to native #1805

Draft

ABCxFF force-pushed the 12-18-chore_services_user_migrate_user_proto_ops branch from ec88581 to d8bc66a Compare January 14, 2025 22:47

ABCxFF mentioned this pull request Jan 14, 2025

chore(users/workflow): setup basic e2e user workflow #1844

Draft

ABCxFF force-pushed the 12-18-chore_services_user_migrate_user_proto_ops branch from d8bc66a to 6fb3d05 Compare January 22, 2025 03:35

ABCxFF mentioned this pull request Jan 22, 2025

feat(user/workflows): profile set signal #1902

Draft

ABCxFF added 10 commits January 22, 2025 21:10

chore(services/user): migrate user-team-list proto op

94740fd

chore(user/team-list): migrate leftover references

4ab838e

chore(user/resolve-email): migrate resolve-email op & refs

96643ff

chore(user/token-create): migrate proto ops & refs

4c3e0d8

chore(user/profile-validate): migrate ops & refs

076e416

chore(users/pending-delete-toggle): migrate proto ops & refs

5f79bad

chore(users/get): migrate old proto and refs

9c75107

chore(user/avatar-upload-complete): migrate ops & refs

06b0a0d

chore(users): migrate user-identity ops to user

19ceecd

chore(user-identity/db): migrate migrations to user

bb69380

ABCxFF mentioned this pull request Jan 22, 2025

feat(users): user wf tests #1935

Draft

ABCxFF force-pushed the 12-18-chore_services_user_migrate_user_proto_ops branch from 6fb3d05 to c1c6586 Compare January 22, 2025 21:10

chore(users): migrate tests

2c153f0

ABCxFF force-pushed the 12-18-chore_services_user_migrate_user_proto_ops branch from c1c6586 to 2c153f0 Compare January 22, 2025 22:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(services/user): migrate user-team-list proto op #1650

chore(services/user): migrate user-team-list proto op #1650

ABCxFF commented Dec 18, 2024

ABCxFF commented Dec 18, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Dec 18, 2024 •

edited

Loading

MasterPtato left a comment

MasterPtato Jan 6, 2025

MasterPtato Jan 6, 2025

MasterPtato Jan 6, 2025

MasterPtato Jan 6, 2025

MasterPtato Jan 6, 2025

MasterPtato Jan 6, 2025

MasterPtato Jan 6, 2025

MasterPtato Jan 6, 2025

MasterPtato Jan 6, 2025

	client: backend::net::ClientInfo {..Default::default()}
	client: backend::net::ClientInfo::default()

chore(services/user): migrate user-team-list proto op #1650

Are you sure you want to change the base?

chore(services/user): migrate user-team-list proto op #1650

Conversation

ABCxFF commented Dec 18, 2024

Changes

ABCxFF commented Dec 18, 2024 • edited Loading

How to use the Graphite Merge Queue

cloudflare-workers-and-pages bot commented Dec 18, 2024 • edited Loading

Deploying rivet with Cloudflare Pages

MasterPtato left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ABCxFF commented Dec 18, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Dec 18, 2024 •

edited

Loading