Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show github stars #1817

Closed
wants to merge 2 commits into from
Closed

Conversation

NicholasKissel
Copy link
Member

@NicholasKissel NicholasKissel commented Jan 9, 2025

Closes WEB-252

Changes

Desktop:
image.png

Mobile:
image.png

Copy link

cloudflare-workers-and-pages bot commented Jan 9, 2025

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 94c1ab2
Status: ✅  Deploy successful!
Preview URL: https://963c4130.rivet.pages.dev
Branch Preview URL: https://01-09-feat-show-github-stars.rivet.pages.dev

View logs

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

linear bot commented Jan 9, 2025

@NicholasKissel NicholasKissel requested a review from jog1t January 9, 2025 22:30
@NicholasKissel NicholasKissel marked this pull request as ready for review January 9, 2025 22:30
Copy link

Deploying rivet-hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: 94c1ab2
Status:🚫  Build failed.

View logs

Copy link
Contributor

graphite-app bot commented Jan 11, 2025

Merge activity

Copy link
Member

@NathanFlurry NathanFlurry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This arrow broke:

CleanShot 2025-01-12 at 20 59 28@2x

This layout looks awful, the icons are not the same size. Make the icons the same size (Discord & GitHub) then add more horizontal spacing between all 3 items:

CleanShot 2025-01-12 at 20 59 49@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants