feat(hub): add dedicated name column for actors & builds #1995

NathanFlurry · 2025-02-03T21:29:35Z

Changes

cloudflare-workers-and-pages · 2025-02-03T21:29:36Z

Deploying rivet-hub with Cloudflare Pages

Latest commit:	`63eb01a`
Status:	✅ Deploy successful!
Preview URL:	https://18caa143.rivet-hub-7jb.pages.dev
Branch Preview URL:	https://02-03-feat-hub-add-dedicated.rivet-hub-7jb.pages.dev

View logs

NathanFlurry · 2025-02-03T21:30:07Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

greptile-apps

PR Summary

This PR adds dedicated name columns for actors and builds, separating the name tag from other tags for better visibility and organization in the UI.

Added new grid column layout in frontend/apps/hub/src/domains/project/components/actors/actors-list.tsx expanding from 6 to 7 columns
Introduced BUILT_IN_TAGS structure in actor-tags.tsx to properly categorize and filter tags for actors vs builds
Enhanced usePatchActorBuildTagsMutation in mutations.ts to handle 'current' tag transitions between builds
Added name tag extraction logic in actors-list-row.tsx with fallback display for missing names
Updated builds table in builds.tsx to properly exclude built-in tags using the new category system

_{5 file(s) reviewed, 9 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-02-03T21:30:11Z

frontend/apps/hub/src/domains/project/components/actors/actors-list-row.tsx

@@ -71,13 +73,17 @@ export const ActorsListRow = memo(
 						/>
 					</SmallText>
 					<SmallText>{id.split("-")[0]}</SmallText>
+					<SmallText>
+						{(tags as Record<string, string>).name ?? "-"}


logic: unsafe type assertion - should validate tags is an object before casting to Record<string, string>

greptile-apps · 2025-02-03T21:30:12Z

frontend/apps/hub/src/domains/project/components/actors/actors-list-row.tsx

@@ -12,6 +12,8 @@ import { ActorRegion } from "./actor-region";
 import { ActorStatusIndicator } from "./actor-status-indicator";
 import { ActorTags } from "./actor-tags";

+const BUILT_IN_TAGS = ["name"];


style: BUILT_IN_TAGS is defined but never used in this file - consider removing or using it to filter tags

greptile-apps · 2025-02-03T21:30:17Z

frontend/apps/hub/src/domains/project/components/actors/actor-tags.tsx

 	tags?: unknown;
-	excludeBuiltIn?: boolean;
+	excludeBuiltIn?: keyof typeof BUILT_IN_TAGS;


style: tags is typed as unknown but used as object in implementation. Consider using Record<string, string> or a more specific type

Suggested change

tags?: unknown;

excludeBuiltIn?: boolean;

excludeBuiltIn?: keyof typeof BUILT_IN_TAGS;

tags?: Record<string, string>;

excludeBuiltIn?: keyof typeof BUILT_IN_TAGS;

greptile-apps · 2025-02-03T21:30:20Z

frontend/apps/hub/src/domains/project/queries/actors/mutations.ts

-		} & Rivet.servers.PatchBuildTagsRequest) =>
-			rivetClient.actor.builds.patchTags(buildId, {
+		} & Rivet.servers.PatchBuildTagsRequest) => {
+			console.log("mutating", request.tags);


style: Remove debug console.log before production deployment

greptile-apps · 2025-02-03T21:30:20Z

frontend/apps/hub/src/domains/project/queries/actors/mutations.ts

+						current: "true",
+					}),
+				});
+				console.log("updating builds", currentBuilds.builds);


style: Remove debug console.log before production deployment

greptile-apps · 2025-02-03T21:30:21Z

frontend/apps/hub/src/domains/project/queries/actors/mutations.ts

+				for (const build of currentBuilds.builds) {
+					await rivetClient.actor.builds.patchTags(build.id, {
+						project: projectNameId,
+						environment: environmentNameId,
+						body: {
+							tags: {
+								current: null,
+							},
+						},
+					});
+				}


style: This loop makes multiple sequential API calls. Consider using Promise.all for better performance

Suggested change

for (const build of currentBuilds.builds) {

await rivetClient.actor.builds.patchTags(build.id, {

project: projectNameId,

environment: environmentNameId,

body: {

tags: {

current: null,

},

},

});

}

await Promise.all(currentBuilds.builds.map(build =>

rivetClient.actor.builds.patchTags(build.id, {

project: projectNameId,

environment: environmentNameId,

body: {

tags: {

current: null,

},

},

})

));

greptile-apps · 2025-02-03T21:30:22Z

frontend/apps/hub/src/domains/project/queries/actors/mutations.ts

+			// If setting build to current, remove current tag from all other builds with the same name
+			if (
+				ogBuild.build.tags.name &&
+				(request.tags as Record<string, string> | undefined)
+					?.current === "true"
+			) {


logic: Type assertion on request.tags could fail silently. Consider adding runtime type validation

greptile-apps · 2025-02-03T21:30:40Z

...es/_authenticated/_layout/projects/$projectNameId/environments/$environmentNameId/builds.tsx

+					await mutateBuildTagsAsync({
 						projectNameId,
 						environmentNameId,
 						buildId: id,
 						tags: { current: "true" },
-						exclusiveTags: ["current"],
 					});


logic: removing exclusiveTags parameter could allow multiple builds to have current=true tag simultaneously, potentially causing inconsistent behavior

greptile-apps · 2025-02-03T21:30:40Z

...es/_authenticated/_layout/projects/$projectNameId/environments/$environmentNameId/builds.tsx

+					if (latestBuilds.length > 0) {
+						mutateUpgradeActors({
 							projectNameId,
 							environmentNameId,
 							buildTags: { current: "true" },
-							tags: { name: latestBulds[0].name },
+							tags: { name: latestBuilds[0].name },
 						});
 					}


style: no error handling for failed mutations - could leave system in inconsistent state if first mutation succeeds but second fails

cloudflare-workers-and-pages · 2025-02-03T21:34:08Z

Deploying rivet with Cloudflare Pages

Latest commit:	`63eb01a`
Status:	✅ Deploy successful!
Preview URL:	https://1ce11a9c.rivet.pages.dev
Branch Preview URL:	https://02-03-feat-hub-add-dedicated.rivet.pages.dev

View logs

graphite-app · 2025-02-04T06:42:52Z

Merge activity

Feb 4, 1:42 AM EST: A user added this pull request to the Graphite merge queue.
Feb 4, 1:43 AM EST: CI is running for this PR on a draft PR: #1999
Feb 4, 1:44 AM EST: A user merged this pull request with the Graphite merge queue via draft PR: #1999.

## Changes

This was referenced Feb 3, 2025

fix(build): fix fetching build by id with null tags #1991

Closed

fix(toolchain): correctly handle current tag with multiple builds with the same name #1992

Closed

chore: update generateArticle script extension to .js #1993

Closed

NathanFlurry mentioned this pull request Feb 3, 2025

chore: limit log output to 100 lines #1994

Closed

greptile-apps bot reviewed Feb 3, 2025

View reviewed changes

NathanFlurry force-pushed the 02-03-feat_hub_add_dedicated_name_column_for_actors_builds branch from a0ed162 to 2c5f0f9 Compare February 3, 2025 21:38

NathanFlurry mentioned this pull request Feb 3, 2025

fix(ci): fix building toolchain #1996

Closed

NathanFlurry force-pushed the 02-03-feat_hub_add_dedicated_name_column_for_actors_builds branch 5 times, most recently from b9b9ec4 to 2c5f0f9 Compare February 3, 2025 21:54

NathanFlurry force-pushed the chore_limit_log_output_to_100_lines branch from bced972 to f86b7c7 Compare February 3, 2025 22:43

NathanFlurry force-pushed the 02-03-feat_hub_add_dedicated_name_column_for_actors_builds branch from 322d2c8 to 537f3d9 Compare February 3, 2025 22:43

feat(hub): add dedicated name column for actors & builds

63eb01a

NathanFlurry force-pushed the chore_limit_log_output_to_100_lines branch from f86b7c7 to 02479da Compare February 4, 2025 02:00

NathanFlurry force-pushed the 02-03-feat_hub_add_dedicated_name_column_for_actors_builds branch from 537f3d9 to 63eb01a Compare February 4, 2025 02:01

graphite-app bot deleted the branch chore_limit_log_output_to_100_lines February 4, 2025 06:44

graphite-app bot closed this Feb 4, 2025

graphite-app bot deleted the 02-03-feat_hub_add_dedicated_name_column_for_actors_builds branch February 4, 2025 06:44

github-actions bot mentioned this pull request Feb 4, 2025

chore(main): release 25.1.0 #1839

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(hub): add dedicated name column for actors & builds #1995

feat(hub): add dedicated name column for actors & builds #1995

NathanFlurry commented Feb 3, 2025

cloudflare-workers-and-pages bot commented Feb 3, 2025 •

edited

Loading

NathanFlurry commented Feb 3, 2025 •

edited

Loading

greptile-apps bot left a comment

greptile-apps bot Feb 3, 2025

greptile-apps bot Feb 3, 2025

greptile-apps bot Feb 3, 2025

greptile-apps bot Feb 3, 2025

greptile-apps bot Feb 3, 2025

greptile-apps bot Feb 3, 2025

greptile-apps bot Feb 3, 2025

greptile-apps bot Feb 3, 2025

greptile-apps bot Feb 3, 2025

cloudflare-workers-and-pages bot commented Feb 3, 2025 •

edited

Loading

graphite-app bot commented Feb 4, 2025 •

edited

Loading

feat(hub): add dedicated name column for actors & builds #1995

feat(hub): add dedicated name column for actors & builds #1995

Conversation

NathanFlurry commented Feb 3, 2025

Changes

cloudflare-workers-and-pages bot commented Feb 3, 2025 • edited Loading

Deploying rivet-hub with Cloudflare Pages

NathanFlurry commented Feb 3, 2025 • edited Loading

How to use the Graphite Merge Queue

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Feb 3, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 3, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 3, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 3, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 3, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 3, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 3, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 3, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 3, 2025

Choose a reason for hiding this comment

cloudflare-workers-and-pages bot commented Feb 3, 2025 • edited Loading

Deploying rivet with Cloudflare Pages

graphite-app bot commented Feb 4, 2025 • edited Loading

Merge activity

cloudflare-workers-and-pages bot commented Feb 3, 2025 •

edited

Loading

NathanFlurry commented Feb 3, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 3, 2025 •

edited

Loading

graphite-app bot commented Feb 4, 2025 •

edited

Loading