chore: move cloud -> addons #2711

abcxff · 2025-07-03T18:26:16Z

Changes

Fixes RVT-4799

Summary by CodeRabbit

Chores
- Expanded workspace configuration to include packages under "addons/packages".
- Updated internal directory paths for component builds.
- Revised documentation comments to reflect updated script locations.

coderabbitai · 2025-07-03T18:26:23Z

Walkthrough

The changes update the monorepo configuration and related scripts to shift package and component management from the "cloud/packages" directory to "addons/packages." This includes updating Yarn workspace paths, build scripts, and documentation comments to reference the new "addons" location.

Changes

Files/Paths	Change Summary
package.json	Added "addons/packages/*" to Yarn workspaces.
scripts/addons/upload-builds.ts	Updated component base directory from "cloud/packages" to "addons/packages".
.../toolchain/src/util/docker/build_remote.rs	Updated documentation comment to reference new script path.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant Yarn
    participant BuildScript
    participant AddonsPackages

    Developer->>Yarn: Run workspace commands
    Yarn->>AddonsPackages: Discover and manage packages in addons/packages/*
    Developer->>BuildScript: Run upload-builds.ts
    BuildScript->>AddonsPackages: Locate components in addons/packages/*

Assessment against linked issues

Objective	Addressed	Explanation
Move cloud -> addons (RVT-4799)	✅

Poem

A hop, a skip, to "addons" we go,
Where packages gather in a tidy new row.
Scripts now point to their burrowed new home,
No more "cloud"—just "addons" to roam!
With carrots and code, we leap with glee,
The monorepo's garden grows for all to see! 🥕

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Clippy (1.86.0)

Updating crates.io index
Updating git repository `https://github.com/rivet-gg/serde_array_query`

error: failed to get serde_array_query as a dependency of package api-helper v25.5.1 (/packages/common/api-helper/build)

Caused by:
failed to load source for dependency serde_array_query

Caused by:
Unable to update https://github.com/rivet-gg/serde_array_query?rev=b9f8bfa#b9f8bfad

Caused by:
failed to create directory /usr/local/git/db/serde_array_query-49d74d117e610833

Caused by:
Permission denied (os error 13)

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9a28ea0 and b5670e3.

⛔ Files ignored due to path filters (2)

addons/packages/ci-manager/yarn.lock is excluded by !**/yarn.lock, !**/*.lock
yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (3)

package.json (1 hunks)
packages/toolchain/toolchain/src/util/docker/build_remote.rs (1 hunks)
scripts/addons/upload-builds.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: cargo-check-main
GitHub Check: claude-review

🔇 Additional comments (3)

package.json (1)

8-8: Migration strategy clarification needed.

The addition of "addons/packages/*" to the workspaces is consistent with the refactoring objective. However, both "cloud/packages/*" and "addons/packages/*" are now present in the workspaces configuration.

Please clarify whether this dual configuration is:

Intentional for a gradual migration period

Temporary until all packages are moved from cloud to addons

Permanent to support packages in both locations

scripts/addons/upload-builds.ts (1)

41-41: All CI components successfully migrated to addons/packages.

Verified that both ci-manager and ci-runner now exist under addons/packages with their respective Dockerfiles, and that no legacy directories remain in cloud/packages. No further action required.

packages/toolchain/toolchain/src/util/docker/build_remote.rs (1)

30-30: LGTM! Documentation updated correctly.

The comment update correctly reflects the new script location and maintains documentation accuracy.

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

claude · 2025-07-03T18:26:31Z

Claude finished @abcxff's task —— View job

PR Review: Move cloud -> addons

Todo List:

Analyze the file structure changes and renaming consistency
Review the modified files for correctness
Check for any missed references or potential breaking changes
Verify dependency updates in package.json and yarn.lock
Provide comprehensive review feedback

🚨 Critical Issue: Incomplete Migration in package.json

Issue: The package.json file still contains both the old and new workspace references:

"workspaces": [
  "frontend/apps/*",
  "frontend/packages/*",
  "addons/packages/*",
  "cloud/packages/*",  // ← This should be removed
  ...
]

Impact: This will cause workspace resolution issues and may lead to build failures or package management problems.

Fix: Remove the "cloud/packages/*" entry from the workspaces array in package.json:9.

✅ Successful Changes

File Structure: All files were successfully moved from cloud/packages/ to addons/packages/
Reference Updates:
- build_remote.rs:30 - Comment correctly updated to reference new upload script path
- upload-builds.ts:41 - Path correctly updated to use addons/packages instead of cloud/packages

🔍 Code Quality Assessment

Positive:

Clean file moves with no content changes to most files
Proper path updates in referencing files
No security concerns identified
Consistent naming convention

No Issues Found:

No performance concerns
No security vulnerabilities
No test coverage issues (tests were moved intact)

📋 Recommendations

Complete the migration by removing "cloud/packages/*" from package.json workspaces
Verify no cloud directory exists in the repository after this change
Run yarn install after the workspace fix to ensure dependency resolution works correctly
Consider running tests to ensure the moved packages still function correctly

📂 Files Changed Summary

22 files renamed/moved (no content changes)
4 files with content modifications (package.json, build_remote.rs, upload-builds.ts, yarn.lock)
Changes are minimal and focused on the path migration

Overall Assessment: This is a straightforward refactoring with one critical issue that needs to be addressed before merging.

abcxff · 2025-07-03T18:26:35Z

feat(cloud): add zod typed apis #2723
chore: move cloud -> addons #2711 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

linear · 2025-07-03T18:26:37Z

RVT-4799 Move cloud -> addons

cloudflare-workers-and-pages · 2025-07-03T18:29:24Z

Deploying rivet with Cloudflare Pages

Latest commit:	`b5670e3`
Status:	✅ Deploy successful!
Preview URL:	https://f1346729.rivet.pages.dev
Branch Preview URL:	https://07-03-chore-move-cloud---add.rivet.pages.dev

View logs

chore: move cloud -> addons

b5670e3

abcxff marked this pull request as ready for review July 3, 2025 18:26

abcxff mentioned this pull request Jul 5, 2025

feat(cloud): add zod typed apis #2723

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: move cloud -> addons #2711

chore: move cloud -> addons #2711

Uh oh!

abcxff commented Jul 3, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 3, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

claude bot commented Jul 3, 2025 •

edited

Loading

Uh oh!

abcxff commented Jul 3, 2025 •

edited

Loading

Uh oh!

linear bot commented Jul 3, 2025

Uh oh!

cloudflare-workers-and-pages bot commented Jul 3, 2025

Uh oh!

Uh oh!

chore: move cloud -> addons #2711

Are you sure you want to change the base?

chore: move cloud -> addons #2711

Uh oh!

Conversation

abcxff commented Jul 3, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Assessment against linked issues

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

claude bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review: Move cloud -> addons

🚨 Critical Issue: Incomplete Migration in package.json

✅ Successful Changes

🔍 Code Quality Assessment

📋 Recommendations

📂 Files Changed Summary

Uh oh!

abcxff commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

linear bot commented Jul 3, 2025

Uh oh!

cloudflare-workers-and-pages bot commented Jul 3, 2025

Deploying rivet with Cloudflare Pages

Uh oh!

Uh oh!

abcxff commented Jul 3, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 3, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

claude bot commented Jul 3, 2025 •

edited

Loading

abcxff commented Jul 3, 2025 •

edited

Loading